Skip to content

Fix live nicknames in Direct and Group chats - #52

Merged
HANCORE-linux merged 1 commit into
mainfrom
fix/group-live-names
Sep 8, 2026
Merged

HANCORE-linux merged 1 commit into
mainfrom
fix/group-live-names

Conversation

@HANCORE-linux

Copy link
Copy Markdown
Owner

Summary

  • Send saved profile nicknames to existing native Tox groups. Include sparse and still-joining groups in the bounded inventory instead of treating the initialized-group count as its endpoint.
  • Publish Friends snapshots after Tox iteration, when native friend-name getters contain the new value, so open DirectChats do not need a panel refresh.
  • Report incomplete group updates with a request-correlated warning rather than a success acknowledgement. Preserve the saved profile, support explicit same-name retries, and retain fail-closed identity handling for uncertain saves.
  • Add native C and helper-IPC fault regressions, two-helper live-name checks, and Panel/Service correlation coverage. No QML-only name substitution or automatic retry queue.

Validation

  • make test and local make test-ci passed; the latter excludes native Quickshell/Omarchy fixtures.
  • sh tests/phase3.sh passed, including unsolicited Direct and Group name updates in both directions, repeated/Unicode changes, and existing groups. No post-rename status/list request or chat message triggers the refresh.
  • Helper build/hardening, architecture and plugin validation, no-Signal build guard, PlainText policy, ShellCheck, Python syntax, and whitespace checks passed.
  • qmllint passed for ChatSurface.qml, pages/ChatPage.qml, and Service.qml.
  • Independent cumulative read-only review found no remaining actionable findings. The joining-group inventory finding was fixed and covered by a reproducing regression.

Limits and earlier failures

  • Native Wayland/two-machine repeat acceptance remains pending; this PR does not deploy the change. Native send acceptance is not acknowledgement from every peer.
  • qmllint Panel.qml still exits 255 without diagnostics; the Panel/Service runtime fixture passed.
  • One earlier phase3 run failed at the existing kick check. A subsequent complete run passed; the earlier cause is not established. Failure diagnostics now report aggregate errors and group changes only.
  • An earlier make test run hit ProcessLookupError while reading /proc in the unchanged emoji process-cleanup test. The full repeat and headless suite passed; that separate test was not modified.

@HANCORE-linux
HANCORE-linux merged commit 3dbbffc into main Sep 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant