personal/egparedes: connectivities as types — address review comments - #34
Merged
Merged
Conversation
- describe only the current design; implementation is a branch/PR pointer - supersede shared/dimensions-as-types (banner, status, index entry) - rename the connectivity's first type parameter Origin -> Domain - explain what each kept runtime/compile-time artifact is and why it stays - present the declaration as the static part of the table's type and state the one-table-per-declaration-per-binding-context invariant - add a Staggered[D] section (meaning, runtime, IR, backends)
- NeighborConnectivityType -> NeighborTableType (declaration, dtype, skip_value, max_neighbors); ts.OffsetType -> ts.ShiftType with domain/codomain/tag; offset_provider_type -> table_types - Implementation section describes the four-PR stack (A #2899, B #2907, C #2910, D #2912) into which the seven PRs are being consolidated - the Origin spelling caveat and the slimming follow-up are resolved
…eighborTableType details - stack #2917: A #2899, B #2907, C #2910, D #2912; #2908/#2909/#2911 closed - NeighborTableType: built from the provider key via owner/sharers, structural fallback for tables without a declaration, check_neighbor_table returns it - TableTypes / TableTypesLike
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks
personal/egparedes/connectivities-as-types/after the author's review:Implementationsection is a branch/PR pointer (connectivities-as-types-8-typed-positions, fix[next]: lower unstructured shifts with the offset's own tag gt4py#2898–#2912).shared/dimensions-as-types. The note is now self-contained on the dimension design (ADR 0028). The shared note gets a superseded banner andstatus: superseded(note: not in the AGENTS.md status vocabulary; the previousproposedwas not either), and its index entry says so. It stays until this proposal moves toshared/.Origin→Domain.NeighborConnectivity[Domain, Codomain],V2E.domain. The claimed ADR 0019 origin of the term was wrong;originalso collides with the buffer origin (__gt_origin__). The gt4py branch still spells itOrigin; the note flags the pending rename.Connectivity,CartesianConnectivity,NeighborTable,NeighborConnectivityTypeandts.OffsetType, and flags the two follow-ups (slimmingNeighborConnectivityType, renamingOffsetType.source/target).Staggered[D]section. Meaning (ADR 0026), runtime representation, embedded shift convention, IR tag grammar and serialization, gtfn/DaCe treatment.Appendices, the typing probe docstring and the index are updated to match.