fix(ci): scope release asset glob + honest spotless check + correct dev version (GADP-055, GADP-041) - #52
Merged
craigpnnl merged 3 commits intoAug 1, 2026
Conversation
The release.yml asset glob (cnf/releaserepo/**/*.jar) attaches every historical release jar in the repo (1278 jars across all versions back to v2.0.45), not just the jars for the tag being released. The 16.0.0 release upload hit GitHub's secondary rate limit inside softprops/action-gh-release and got stuck in Draft. Derive the release version from the tag (github.ref_name, leading 'v' stripped) and narrow the glob to cnf/releaserepo/**/*-<version>.jar, so only the current release's jars (16, one per module) are attached instead of the full history. The dist/*.tar.gz source and binary archive attachments are unchanged; they were not part of the bloat. The separate GOSS-Repository Maven index push (push-to-local-goss-repository.py) is untouched.
./gradlew spotlessCheck --no-daemon || true in the spotless job made the 'Code Formatting Check' check permanently green regardless of outcome, letting a real formatting violation merge on PR GridOPTICS#50 while the separate honest gate in format-check.yml reported the failure correctly. Remove the || true so this job fails honestly on a real formatting violation. The quality-gate job already excludes spotless.result from its pass/fail decision (it only hard-fails on dependency-check), so this does not turn spotless into an unintended new blocker on the overall pipeline; it only fixes the per-check status shown on the PR.
…SNAPSHOT v16.0.0 never actually shipped (the release stuck in Draft, tag deleted). This reverts the version-only content of ef1826c (Prepare next development iteration (16.0.1-SNAPSHOT)) and restores the SNAPSHOT qualifier across all 17 OSGi bundle .bnd files so develop reflects an in-progress 16.0.0, not a released 16.0.0 or a premature 16.0.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Narrows release.yml asset glob to current-version jars (stops the ~550-asset upload that tripped the secondary rate limit and left releases in Draft); removes || true so the spotless check fails honestly; reverts the premature 16.0.1-SNAPSHOT bump back to 16.0.0-SNAPSHOT since v16.0.0 never shipped. Dutch-reviewed APPROVE-WITH-NITS.