Repository navigation
Run CI on gravitypdf-v6 - #821
Merged
Merged
Conversation
Upstream's workflows only run on push to master, development and test, so a merge into gravitypdf-v6 got no CI. Add the branch to their push triggers, and workflow_dispatch so a run can be started by hand. No schedules, to keep the fork's Actions usage down. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PHPStan 2.3.2 counts Table.php's baselined $added_page error 3 times on PHP 8.2 but 5 on 8.5, so no baseline satisfies both; pin 2.3.1, which upstream last passed with. ubuntu-latest is now 26.04, which has no /etc/ImageMagick-6, so edit whichever policy exists and only its PDF rule, as the gravitypdf branch does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gravitypdf-v6carries upstream mPDF's workflows, which only run on push tomaster,developmentandtest, so merges into it (#819, #820) got no CI. This adds the branch to the push triggers of the tests, coding standard, static analysis and snapshot workflows, and addsworkflow_dispatchso a run can be started by hand.gravitypdf-v6added topush.branchesintests.yml,cs.yml,static-analysis.ymlandsnapshots.yml.workflow_dispatchadded to the same four.Try it
After merging, the push to
gravitypdf-v6starts all four workflows. Actions → Tests → Run workflow ongravitypdf-v6also works.Test plan
gravitypdf-v6with Drop float records the layout has already buried (v6) #819 and Accept an existing cache directory that is_writable() calls read-only (v6) #820 in it, which have had no CI so far.gravitypdf-v6runs the four workflows.More info
coverage.ymlis left alone, since it needs Codecov.🤖 Generated with AI