Repository navigation
Support the CSS-wide keywords inherit, initial, unset and revert #546
Description
Part of #520 (step 25).
Measured on gravitypdf at d660a410, PHP 8.5.4.
| Rules | Element | Browser | mPDF |
|---|---|---|---|
.a{color:#0f0} p{color:red} p.b{color:inherit} |
<div class="a"><p class="b"> |
green | black |
.a{color:#0f0} p{color:red} p.b{color:unset} |
the same | green | black |
.a{color:#0f0} p{color:red} p.b{color:revert} |
the same | green | black |
.a{font-size:20pt} p{font-size:8pt} p.b{font-size:inherit} |
the same | 20pt | 11pt |
.a{font-weight:bold} p{font-weight:normal} p.b{font-weight:inherit} |
the same | bold | normal |
table{color:#0f0} td{color:red} td.b{color:inherit} |
<td class="b"> |
green | black |
div{border:1px solid red} p{border:inherit} |
<div><p> |
two borders | one |
inherit on an inline element happens to work, because the unknown value is ignored and the element keeps its parent's state. ColorConverter treats inherit as transparent (src/Color/ColorConverter.php:43), and NormalizeProperties strips inherit from the background shorthand.
Fix. Resolve the keywords in CssMerger after the cascade:
inherit: the parent's computed value. For inherited properties that is the state the element starts from. For the others (border,padding,backgroundand so on), it comes from the frames of Track the stack of open elements while parsing HTML #533.initial: the property's initial value, from a table of them.unset:inheritfor inherited properties,initialfor the others.revert: the built-in default for the element (DefaultCss), thenunset.
Remove the special cases in ColorConverter and NormalizeProperties.
Tests. Each keyword on a block, an inline element and a cell, for an inherited and a non-inherited property.
Depends on #533 for non-inherited properties. Unblocks #547.
Activity