Skip to content

Fix the template docs link picking up the Add New Template tile styles (6.18.0) - #1980

Merged
jakejackson1 merged 1 commit into
hot-patch-6.18.0from
fix/template-docs-link-style-6.18.0
Oct 27, 2026
Merged

jakejackson1 merged 1 commit into
hot-patch-6.18.0from
fix/template-docs-link-style-6.18.0

Conversation

@gravitypdf-bot

Copy link
Copy Markdown
Contributor

Summary

The "Learn to create your own template." link under the Add New Template tile (added in 38fb6e1) is rendered inside the .theme.add-new-theme element, so WordPress core's .theme-browser .theme.add-new-theme a rules hit it too: it became a block with a hidden dashed overlay that filled solid blue on hover, hiding the text. This resets those rules on the instructions link so it renders as a normal inline link.

  • _template-manager.scss: the .gfpdf-template-install-instructions a link is reset to display: inline, underlined, with core's ::after overlay removed.
  • _template-manager.scss: the disabled tile's pointer-events: none now targets only the tile link (> a), so the docs link stays clickable when uploads are disabled.

Development doesn't have the docs link in the tile, so this is a hot-patch-only fix.

Try it

  1. Go to Forms → Settings → PDF and open the Template Manager.
  2. Scroll to the Add New Template tile: "Learn to create your own template." is an underlined link under the instructions.
  3. Hover it: no blue box appears, and the tile itself still highlights blue when you hover the tile.

Test plan

  • CI passes
  • Docs link looks and behaves like a normal link, at rest and on hover/focus
  • Add New Template tile hover and click (file picker) unchanged
  • With uploads disabled (DISALLOW_FILE_MODS), the tile is dimmed and unclickable, and the docs link still opens

… styles

The docs link sits inside the .theme.add-new-theme tile, so core's tile link rules made it a block with a dashed
overlay that turned solid blue on hover. Reset them on the instructions link, and scope the disabled tile's
pointer-events block to the tile link so the docs link stays clickable.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jakejackson1
jakejackson1 merged commit 4bf905a into hot-patch-6.18.0 Oct 27, 2026
13 checks passed
@jakejackson1
jakejackson1 deleted the fix/template-docs-link-style-6.18.0 branch October 27, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants