Repository navigation
Upload release assets to a draft, then publish it (6.18.0) - #1978
Merged
jakejackson1 merged 1 commit intoOct 27, 2026
Merged
Conversation
Immutable releases reject asset uploads once a release is published, and action-gh-release publishes prereleases before uploading, so 6.18.0-RC4 went out with no zip or checksum. Create the release as a draft, attach the assets, then publish the draft by ID. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gravitypdf-bot
added
Bug
github_actions
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 6.18.0-RC4 release run failed: the repo now has immutable releases, and
action-gh-releasepublishes a prerelease before uploading its assets, so GitHub rejected the zip and checksum and RC4 went out empty. This PR creates the release as a draft, attaches the assets, then publishes the draft.draft: trueto the release step so assets upload before the release is published.Try it
Test plan
actionlintpassesgravity-pdf-<version>.zipand.zip.sha256attachedMore info
Failed run: https://github.com/GravityPDF/gravity-pdf/actions/runs/40593592379
release.publishedrather thanrelease.prereleased. Nothing in this repo listens for release events, but any external listener keyed onprereleasedwill need updating.workflow_dispatchrun the tag doesn't exist yet; GitHub creates it attarget_commitishwhen the draft is published.developmenthas the same workflow and needs the same change.