Repository navigation
Use the form's description placement for Consent fields set to "Use Form Setting" (6.18.0) - #1964
Merged
jakejackson1 merged 2 commits intoOct 26, 2026
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #1960 to 6.18.0. Consent fields left on the default "Use Form Setting" description placement always printed their description below the checkbox in PDFs, even when the form's Description Placement was "Above inputs". The Consent field now falls back to the form's setting when the field doesn't set one.
Try it
Or by hand: on a form with a Consent field, set Form Settings > Form Layout > Description Placement to "Above inputs", leave the Consent field's Description Placement on "Use Form Setting", submit an entry and view a Core PDF (e.g. Zadani). The consent description now prints above the tick.
Test plan
Test_Field_ConsentpassesMore info
Cherry-pick of #1960's squash commit (c47d9c1), which applied cleanly;
Field_Consent.phpwas identical on both branches. The test lands in 6.18'stests/phpunit/unit-tests/Helper/Fields/Test_Field_Consent.php. The only other change is the CHANGELOG line, added at the end of the 🐞 Bug group under 6.18.0.Checks run locally on the 6.18 build (own test DB):
Test_Field_Consent8/8 passing; withField_Consent.phpreverted tohot-patch-6.18.0, the two "inherits form" cases fail as expected. PHPCS (phpcs.xml.distandphpcompat.xml.dist) clean on the changed source. The full suite was not run locally; CI covers it.See #1960 for why
GF_Field::is_description_above()wasn't used.🤖 Generated with AI