feat(tar driver): add OCI layout tar driver support#554
feat(tar driver): add OCI layout tar driver support#554malt3 wants to merge 1 commit intoGoogleContainerTools:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for OCI layouts when using the Tar driver. It updates the CLI to accept the --image-from-oci-layout flag for both Docker and Tar drivers, introduces a new ImageFromV1 utility for filesystem extraction, and implements OCI layout handling within the TarDriver. Additionally, several architecture-specific test configurations and a new integration test case were included. Review feedback identifies a bug in a logrus.Fatalf call where a format argument is missing, suggests refactoring duplicated OCI layout logic into a shared utility, and points out a potential directory leak in ImageFromV1 if filesystem extraction fails.
Add support for OCI layout with tar driver: - Extend tar driver to handle OCI layout directories directly - Add OCILayout field to DriverConfig for tar driver configuration - Implement imageFromOCILayout function to load images from OCI layout - Add ImageFromV1 utility function to create Image from v1.Image - Update --image-from-oci-layout to support both Docker and Tar drivers Add test coverage: - Add Ubuntu 22.04 tar test configurations for amd64, arm64, ppc64le, and s390x architectures - Add test case for OCI layout with tar driver in test script Closes GoogleContainerTools#461
malt3
force-pushed
the
publish-tar_driver_support_oci_layout
branch
from
f42988b to
23e375c
Compare
|
@loosebazooka could you TAL when you get a few minutes? 🙏🏻 |
2 participants
Add support for OCI layout with tar driver:
Add test coverage:
Closes #461