Repository navigation
Conversation
…and fix sample bugs - Upgrade dependencies and Python runtime (3.13 / Apache Beam 2.77.0) to resolve Dependabot alerts. - Fix sample build and test issues discovered during verification (update Dockerfile/packaging, add .gcloudignore, and normalize bucket URI in conftest.py).
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Python version from 3.14 to 3.13 and upgrades the Apache Beam SDK to version 2.77.0 across the pipeline_with_dependencies flex template files, including the Dockerfile, pyproject.toml, and requirements files. It also introduces a .gcloudignore file and modifies conftest.py to strip the 'gs://' prefix from the GOOGLE_CLOUD_BUCKET environment variable. Regarding the feedback, it is recommended to use .removeprefix('gs://').rstrip('/') in conftest.py to make the bucket name parsing cleaner and more robust against trailing slashes.
XrossFox
marked this pull request as ready for review
October 20, 2026 23:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes b/573677639
Checklist
Testing
Compliance & Style
Post-Approval Actions