deps(compute): update dependencies across compute samples - #4481
angelcaamal wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Node.js engine requirement to version 20 or higher and upgrades several dependencies in compute/package.json, including @google-cloud/compute, @google-cloud/storage, c8, and chai. The review feedback highlights a critical issue where upgrading chai to ^6.0.0 will break the test suite because Chai v5 and above are ESM-only, whereas the project uses CommonJS (require). It is recommended to keep chai at ^4.5.0 to prevent runtime errors.
| "chai": "^4.5.0", | ||
| "@google-cloud/storage": "^8.0.0", | ||
| "c8": "^12.0.0", | ||
| "chai": "^6.0.0", |
There was a problem hiding this comment.
Upgrading chai to ^6.0.0 will break the test suite if the tests are written using CommonJS (require). Chai v5.0.0 and above are ESM-only. Since compute/test/util.js and other files in this project use CommonJS (require), please keep chai at ^4.5.0 to avoid ERR_REQUIRE_ESM errors during test execution.
| "chai": "^6.0.0", | |
| "chai": "^4.5.0", |
Description
Fixes b/565493698
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.