Skip to content

deps(compute): update dependencies across compute samples - #4481

Draft
angelcaamal wants to merge 1 commit into
mainfrom
deps-update-compute-samples
Draft

angelcaamal wants to merge 1 commit into
mainfrom
deps-update-compute-samples

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Description

Fixes b/565493698

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples. labels Sep 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Node.js engine requirement to version 20 or higher and upgrades several dependencies in compute/package.json, including @google-cloud/compute, @google-cloud/storage, c8, and chai. The review feedback highlights a critical issue where upgrading chai to ^6.0.0 will break the test suite because Chai v5 and above are ESM-only, whereas the project uses CommonJS (require). It is recommended to keep chai at ^4.5.0 to prevent runtime errors.

Comment thread compute/package.json
"chai": "^4.5.0",
"@google-cloud/storage": "^8.0.0",
"c8": "^12.0.0",
"chai": "^6.0.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading chai to ^6.0.0 will break the test suite if the tests are written using CommonJS (require). Chai v5.0.0 and above are ESM-only. Since compute/test/util.js and other files in this project use CommonJS (require), please keep chai at ^4.5.0 to avoid ERR_REQUIRE_ESM errors during test execution.

Suggested change
"chai": "^6.0.0",
"chai": "^4.5.0",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant