viewer: resolve bundle-root-absolute links into graph edges - #283
Open
tungamajunga wants to merge 2 commits into
Open
viewer: resolve bundle-root-absolute links into graph edges#283tungamajunga wants to merge 2 commits into
tungamajunga wants to merge 2 commits into
Conversation
SPEC.md §6.1 defines two cross-linking forms and recommends the absolute (bundle-relative) one beginning with "/". The viewer's _extract_links dropped those targets, so bundles using the recommended form rendered with no edges at all. Resolve them against the bundle root instead; targets that escape the root are still rejected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Producer-internal state (a .oknoll/ revision store, .git/) is not bundle content; walking it duplicated every concept node once per snapshot when the viewer was pointed at a working bundle directory. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SPEC.md§6.1 defines two cross-linking forms and recommends the absolute (bundle-relative) one beginning with/:The viewer's
_extract_linksinreference_agent/viewer/generator.pydrops any target starting with/, so a bundle whose links use the spec's recommended form rendersviz.htmlwith nodes but zero edges.Minimal repro (a producer emitting spec-recommended links, run through
reference_agent visualizebefore/after this change):](/references/x.md))Changes
_extract_links:/-prefixed targets now resolve against the bundle root per SPEC §6.1; relative targets behave exactly as before, and targets that escape the bundle root are still rejected (covered by a new traversal test)._walk_concepts(separate commit): skip hidden directories, so producer-internal state (a.oknoll/revision store,.git/) pointed-at working directories no longer duplicates every concept node.All existing tests pass; three tests added (
absolute links become edges,absolute links cannot escape the bundle root,hidden directories are not walked).🤖 Generated with Claude Code