Skip to content

fix: clarify frontmatter path resolution - #280

Open
Cu19aaa wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
Cu19aaa:fix/clarify-frontmatter-path-resolution
Open

fix: clarify frontmatter path resolution#280
Cu19aaa wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
Cu19aaa:fix/clarify-frontmatter-path-resolution

Conversation

@Cu19aaa

@Cu19aaa Cu19aaa commented Aug 9, 2026

Copy link
Copy Markdown

Summary

  • Add resolve_reference_path() for resolving OKF frontmatter references consistently.
  • Keep absolute URLs unchanged and resolve bundle-relative paths safely.
  • Prevent relative references from escaping the bundle root.
  • Add tests covering URLs, bundle-relative paths, nested paths, and escape attempts.

Testing

  • python -m pytest -q
  • 47 tests passed
  • git diff --cached --check passed

@google-cla

google-cla Bot commented Aug 9, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant