Restrict API endpoint overrides to trusted Google domains#1188
Open
JeffLuoo wants to merge 1 commit into
Open
Conversation
Enforce that the hostname supplied to --api-override falls under the googleapis.com domain hierarchy. Preventing arbitrary destination overrides avoids leaking the pod's GCE Service Account authorization tokens to untrusted third-party endpoints. Change-Id: I960e0cfbcbb7059670c3de5b76ff659104c77b6e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce that the hostname supplied to --api-override falls under the googleapis.com domain hierarchy..