Repository navigation
fix(models): support impersonated ADC credentials in claude_code and codex_cli - #706
Open
ikenwan-dev wants to merge 1 commit into
Open
ikenwan-dev wants to merge 1 commit into
ikenwan-dev wants to merge 1 commit into
Conversation
ikenwan-dev
requested review from
IsmailMehdi,
helloeve and
prernakakkar-google
as code owners
November 6, 2026 18:46
…r and CodexCliGenerator
ikenwan-dev
force-pushed
the
fix-impersonated-adc-auth
branch
from
November 6, 2026 20:00
74eb149 to
b455cdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MCP google_credentials authentication and Vertex AI ADC resolution when running with service account impersonation (/tmp_sessions/impersonated_adc.json + CLOUDSDK_AUTH_IMPERSONATE_SERVICE_ACCOUNT) on GKE:
GOOGLE_APPLICATION_CREDENTIALSby copying it to the sandboxed ADC path before falling back to/etc/evalbench-sa-key/key.json.CLOUDSDK_AUTH_IMPERSONATE_SERVICE_ACCOUNTand pointGOOGLE_APPLICATION_CREDENTIALSat the source key (/etc/evalbench-sa-key/key.json) when invokinggcloud auth application-default print-access-tokenin_fetch_gcloud_access_token()and Claude Code'sheadersHelper.