Adds dependencies needed for Dataflow ML support - #4310
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces necessary dependencies to support Machine Learning workflows within Dataflow templates. By including 'sentence-transformers' and 'tensorflow', the changes enable users to leverage ML capabilities directly within their YAML-based pipeline configurations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds sentence-transformers and tensorflow to support Dataflow ML. Feedback highlights that these heavy packages should not be added to DEFAULT_DEPENDENCIES in main.py as they are already pre-installed in the base container, and listing them there increases worker startup times and risks breaking private network pipelines. Additionally, it is recommended to pin these dependencies to specific, compatible versions in default_base_yaml_requirements.txt to prevent dependency conflicts and ensure reproducible builds.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #4310 +/- ##
=============================================
- Coverage 56.34% 38.05% -18.30%
+ Complexity 7856 513 -7343
=============================================
Files 1155 195 -960
Lines 73226 11799 -61427
Branches 8585 1190 -7395
=============================================
- Hits 41259 4490 -36769
+ Misses 29183 6941 -22242
+ Partials 2784 368 -2416
🚀 New features to boost your workflow:
|
Needed to add Dataflow ML support to the YAML template and Job builder.
These dependencies are used by following features.