Skip to content

Use opentelementry-bom to manage versions - #4299

Open
kennknowles wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
kennknowles:IT-Failure
Open

kennknowles wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
kennknowles:IT-Failure

Conversation

@kennknowles

Copy link
Copy Markdown
Contributor

Fixes failures such as https://github.com/GoogleCloudPlatform/DataflowTemplates/actions/runs/33453848741 which are caused by dependency downgrade:

  +- com.google.cloud:google-cloud-spanner:test-jar:tests:6.113.0:test
  |  \- io.opentelemetry:opentelemetry-sdk-metrics:jar:1.51.0          <-- WINS
  +- com.google.cloud:google-cloud-spanner:jar:6.121.0:compile
  |  \- (io.opentelemetry:opentelemetry-sdk-metrics:jar:1.62.0 - omitted for conflict with 1.51.0)

Internal tracking bug b/555717934

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses dependency conflict issues where OpenTelemetry libraries were being incorrectly downgraded by transitive dependencies. By importing the OpenTelemetry BOM and pinning the version, the project ensures that all OpenTelemetry components remain at the required version, preventing runtime failures related to mismatched SDK versions.

Highlights

  • Dependency Management: Added opentelemetry-bom to the project's dependency management section to ensure consistent versioning of OpenTelemetry artifacts.
  • Version Pinning: Defined an explicit opentelemetry.version property set to 1.62.0 to prevent unintended dependency downgrades caused by Maven's nearest-wins resolution strategy.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the opentelemetry-bom dependency to the pom.xml to manage OpenTelemetry versions consistently. The feedback points out that the order of BOM imports in Maven is critical; importing opentelemetry-bom after the Beam BOM could lead to mixed-version classpath issues. It is recommended to move the opentelemetry-bom import before the Beam BOM to ensure the correct version takes precedence.

Comment thread pom.xml Outdated
@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.34%. Comparing base (4364622) to head (643d3f5).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #4299       +/-   ##
=============================================
+ Coverage     34.34%   56.34%   +21.99%     
- Complexity      524     7403     +6879     
=============================================
  Files           216     1155      +939     
  Lines         13274    73226    +59952     
  Branches       1322     8585     +7263     
=============================================
+ Hits           4559    41258    +36699     
- Misses         8345    29180    +20835     
- Partials        370     2788     +2418     
Components Coverage Δ
spanner-templates 84.46% <ø> (∅)
spanner-import-export 69.01% <ø> (∅)
spanner-live-forward-migration 88.91% <ø> (∅)
spanner-live-reverse-replication 80.82% <ø> (∅)
spanner-bulk-migration 88.96% <ø> (∅)
gcs-spanner-dv 88.02% <ø> (∅)
see 964 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stankiewicz

Copy link
Copy Markdown
Contributor

Caused by: java.sql.SQLException: ORA-01017: invalid username/password; logon denied ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants