Use opentelementry-bom to manage versions - #4299
kennknowles wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses dependency conflict issues where OpenTelemetry libraries were being incorrectly downgraded by transitive dependencies. By importing the OpenTelemetry BOM and pinning the version, the project ensures that all OpenTelemetry components remain at the required version, preventing runtime failures related to mismatched SDK versions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds the opentelemetry-bom dependency to the pom.xml to manage OpenTelemetry versions consistently. The feedback points out that the order of BOM imports in Maven is critical; importing opentelemetry-bom after the Beam BOM could lead to mixed-version classpath issues. It is recommended to move the opentelemetry-bom import before the Beam BOM to ensure the correct version takes precedence.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4299 +/- ##
=============================================
+ Coverage 34.34% 56.34% +21.99%
- Complexity 524 7403 +6879
=============================================
Files 216 1155 +939
Lines 13274 73226 +59952
Branches 1322 8585 +7263
=============================================
+ Hits 4559 41258 +36699
- Misses 8345 29180 +20835
- Partials 370 2788 +2418
🚀 New features to boost your workflow:
|
|
Caused by: java.sql.SQLException: ORA-01017: invalid username/password; logon denied .. |
9ac65de to
643d3f5
Compare
Fixes failures such as https://github.com/GoogleCloudPlatform/DataflowTemplates/actions/runs/33453848741 which are caused by dependency downgrade:
Internal tracking bug b/555717934