fix(goodreserve-widget): make register wallet-host compatible and prep 0.1.1 publish - #161
Merged
Merged
Conversation
- Updated version in package.json to 0.1.1. - Added "files" and "sideEffects" fields to package.json for better module handling. - Enhanced the register function in register.ts to include package metadata and handle dynamic imports for the GoodReserveWidgetElement.
blueogin
requested review from
a team and
L03TJ3
and
a lite review from Copilot
August 12, 2026 15:56
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GoodReserve widget’s registration entrypoint and packaging metadata to better support wallet-host usage and SSR-safe consumption, while preparing a publishable dist-only artifact set.
Changes:
- Exported
goodWidgetMetadatafrom@goodwidget/goodreserve-widget/registerand maderegister()SSR-safe viatypeof customElementsguard + lazy./elementimport. - Converted
register()to async and aligned it with the registration pattern used in other widgets. - Updated package publishing metadata (
files,sideEffects,bump-version) and bumped package version to0.1.1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/goodreserve-widget/src/register.ts | Adds exported module metadata and changes custom-element registration to an SSR-safe async flow. |
| packages/goodreserve-widget/package.json | Adjusts publish/package metadata (dist-only, sideEffects, bump script) and bumps version. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| packageVersion: '0.1.1', | ||
| } as const | ||
|
|
||
| export async function register(tagName: string = DEFAULT_TAG_NAME): Promise<string> { |
Comment on lines
+3
to
+6
| export const goodWidgetMetadata = { | ||
| packageName: '@goodwidget/goodreserve-widget', | ||
| packageVersion: '0.1.1', | ||
| } as const |
| { | ||
| "name": "@goodwidget/goodreserve-widget", | ||
| "version": "0.1.0", | ||
| "version": "0.1.1", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
goodWidgetMetadatafrom@goodwidget/goodreserve-widget/registerso wallet hosts can callassertWidgetModuleMetadata.registerSSR-safe (async,typeof customElementsguard, lazy./elementimport), matching AI Credits / Superfluid.files,sideEffects,bump-version) and bump to0.1.1so packed/published artifacts shipdistonly.About # (link your issue here)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: