Sammajayi/connect a wallet fixes - #135
Open
sammajayi wants to merge 1 commit into
Open
Conversation
- Fix missing Alert import crash on error/unsupported states - Remove unused address prop from ChainLinkRow (lint fix) - Restructure PrimaryIdentityCard layout (shield/text/copy) - Reduce GlowCard shadow opacity and radius - Update unlink SVG path to match lucide icon - Add flexWrap to ChainLinkRow for 320px viewport support - Reduce input/button sizes for small viewports - Center address in verified identity box with wide gap - Adjust heading spacing and checkmark position - Update Playwright test screenshots
sammajayi
force-pushed
the
sammajayi/connect-a-wallet-fixes
branch
from
July 30, 2026 11:24
bbfde2f to
ed45fce
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the Connect-a-wallet widget by aligning its UI more closely with the design reference, improving responsiveness on small viewports, and hardening edge/error states. It also updates supporting UI primitives and Playwright state tests to match the new copy and layout.
Changes:
- Updated Connect-a-wallet widget view/layout (header, info callout, responsive chain rows, revised copy) and improved small-viewport behavior.
- Added
link/unlinkicons and tunedGlowCardshadow styling to better match the design system. - Hardened Playwright state tests with a more reliable “wait until rendered” helper and added mobile/desktop layout screenshots.
Reviewed changes
Copilot reviewed 8 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/widgets/connect-a-wallet-widget/states.spec.ts | Improves test stability via waitForText and adds mobile/desktop layout coverage. |
| packages/ui/src/components/Icon.tsx | Adds link / unlink SVG paths for the redesigned connect/disconnect buttons. |
| packages/ui/src/components/GlowCard.ts | Adjusts glow shadow intensity/radius to better fit updated visual style. |
| packages/connect-a-wallet-widget/src/components/shared.tsx | Allows chain row card wrapping and simplifies ActionButton sizing for responsiveness. |
| packages/connect-a-wallet-widget/src/components/PrimaryIdentityCard.tsx | Redesigns the primary identity card and adds copy-to-clipboard affordance. |
| packages/connect-a-wallet-widget/src/components/ConnectAWalletWidgetView.tsx | Restructures the widget layout (header/callout/footer) and changes form/ready-state rendering. |
| packages/connect-a-wallet-widget/src/components/ChainLinkRow.tsx | Redesigns per-chain rows with status indicator + icon buttons and wrapping layout. |
| packages/connect-a-wallet-widget/src/components/AddressLinkForm.tsx | Updates form copy/typography and input/button sizing. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| ) | ||
| } | ||
|
|
||
| const showForm = state.status !== 'error' && !(state.status === 'ready' && state.secondaryAddress) |
| width={40} | ||
| height={40} | ||
| borderRadius="$2" | ||
| backgroundColor="rgba(0, 174, 255, 0.15)" |
Comment on lines
+59
to
+67
| <YStack | ||
| onPress={handleCopy} | ||
| cursor="pointer" | ||
| padding="$1" | ||
| hoverStyle={{ opacity: 0.7 }} | ||
| flexShrink={0} | ||
| > | ||
| <Icon name={copied ? 'check' : 'copy'} size="md" color={copied ? 'success' : 'muted'} /> | ||
| </YStack> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Redesigned the connect-wallet widget UI following the design reference in #113 in reference to the main pr in #116, executed following the plan in #114 . Fixed crash on error/unsupported states, addressed overflow on small viewports, and updated component styling to match the design system.
PR about #116
How Has This Been Tested?
Checklist: