Skip to content

fix(ci): use --workspace for publish dry-run preflight#95

Merged
Artifizer merged 1 commit into
GlobalTypeSystem:mainfrom
aviator5:fix-release
Jun 5, 2026
Merged

fix(ci): use --workspace for publish dry-run preflight#95
Artifizer merged 1 commit into
GlobalTypeSystem:mainfrom
aviator5:fix-release

Conversation

@aviator5

@aviator5 aviator5 commented Jun 5, 2026

Copy link
Copy Markdown
Contributor
  • Per-crate dry-run resolves internal deps against crates.io, which fails on a version bump before the new version is published
  • --workspace resolves deps against locally packaged crates and skips publish=false members
  • Requires cargo >= 1.90

Summary by CodeRabbit

  • Chores
    • Improved the release workflow's preflight validation process to enhance consistency and reliability checks across all publishable components.

- Per-crate dry-run resolves internal deps against crates.io, which fails on a version bump before the new version is published
- --workspace resolves deps against locally packaged crates and skips publish=false members
- Requires cargo >= 1.90

Signed-off-by: Aviator 5 <ai.agent.tor@gmail.com>
@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 00fd9567-6e06-40ea-9814-05f1c2bbe690

📥 Commits

Reviewing files that changed from the base of the PR and between d1044f2 and ab71524.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

The release workflow's publish-crates job consolidates its preflight validation from running individual per-crate cargo publish --dry-run commands to a single workspace-wide cargo publish --workspace --dry-run --locked operation that validates all publishable crates simultaneously.

Changes

CI Publish Workflow Optimization

Layer / File(s) Summary
Publish preflight validation consolidation
.github/workflows/release.yml
Per-crate publish dry-run validation is consolidated into a single workspace-wide cargo publish --workspace --dry-run --locked call. Workspace resolution validates internal path-dependency and version consistency using locally packaged crates.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • Artifizer

Poem

🐰 One wash, one check, all crates align,
No more loops through each single line,
The workspace speaks in harmony true,
Packaging validated, dry and through! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately describes the main change: switching from per-crate to workspace-based cargo publish dry-run validation in the CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Artifizer Artifizer merged commit b3433f2 into GlobalTypeSystem:main Jun 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants