fix: disable LayoutAnimation in KeyboardCompatibleView (#3789) - #3790
Merged
Conversation
## 🎯 Goal
It would appear that in `react-native-reanimated` version `4.6.0` and
onwards, the swallowing of `LayoutAnimation.configureNext` in Reanimated
has been fixed. However, this now causes our keyboard animations to
struggle with the Reanimated animation due to the fact that they are
both trying to animate the layout.
I somehow missed this in the RN 0.87 upgrade, but it should be fixed
here.
To address it, we disable the `LayoutAnimation` in our
`KeyboardCompatibleView` because:
1. It never worked pre `4.6.0` of `reanimated`
2. Where it does work, it's interfering with the actual layout animation
So this change basically makes sure we have the old behaviour again.
## 🛠 Implementation details
<!-- Provide a description of the implementation -->
## 🎨 UI Changes
<!-- Add relevant screenshots -->
<details>
<summary>iOS</summary>
<table>
<thead>
<tr>
<td>Before</td>
<td>After</td>
</tr>
</thead>
<tbody>
<tr>
<td>
<!--<img src="" /> -->
</td>
<td>
<!--<img src="" /> -->
</td>
</tr>
</tbody>
</table>
</details>
<details>
<summary>Android</summary>
<table>
<thead>
<tr>
<td>Before</td>
<td>After</td>
</tr>
</thead>
<tbody>
<tr>
<td>
<!--<img src="" /> -->
</td>
<td>
<!--<img src="" /> -->
</td>
</tr>
</tbody>
</table>
</details>
## 🧪 Testing
<!-- Explain how this change can be tested (or why it can't be tested)
-->
## ☑️ Checklist
- [ ] I have signed the [Stream
CLA](https://docs.google.com/forms/d/e/1FAIpQLScFKsKkAJI7mhCr7K9rEIOpqIDThrWxuvxnwUq2XkHyG154vQ/viewform)
(required)
- [ ] PR targets the `develop` branch
- [ ] Documentation is updated
- [ ] New code is tested in main example apps, including all possible
scenarios
- [ ] SampleApp iOS and Android
- [ ] Expo iOS and Android
Contributor
SDK Size
|
Contributor
|
🎉 This PR is included in version 9.8.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
It would appear that in
react-native-reanimatedversion4.6.0and onwards, the swallowing ofLayoutAnimation.configureNextin Reanimated has been fixed. However, this now causes our keyboard animations to struggle with the Reanimated animation due to the fact that they are both trying to animate the layout.I somehow missed this in the RN 0.87 upgrade, but it should be fixed here.
To address it, we disable the
LayoutAnimationin ourKeyboardCompatibleViewbecause:4.6.0ofreanimatedSo this change basically makes sure we have the old behaviour again.
🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch🎯 Goal
🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch