fix(module): drop clear_caches() call removed in Odoo 19 - #237
Closed
bosd wants to merge 1 commit into
Closed
Conversation
ir.module.module.clear_caches() no longer exists / is not RPC-exposed in Odoo 19, so 'fluvo module update-list' 404s (and 'install' cascades into a TypeError). The call is also unnecessary: update_list() scans and commits server-side, and the following search_count([]) is a fresh RPC read that already reflects the updated list. Fixes #236
Member
Author
|
Thanks — adopted your removal approach in #279 (rebased onto current master). #236 itself was already closed by #266, which fixed both the clear_caches 404 and the secondary read() TypeError you'd flagged as a follow-up. #279 swaps #266's try/except guard for your cleaner outright removal (no wasted round-trip on Odoo 19). Closing this in favour of #279. |
bosd
added a commit
that referenced
this pull request
Aug 18, 2026
#266 fixed #236 by guarding clear_caches() in try/except; this adopts bosd's cleaner approach from #237 and drops the call entirely. It was removed from the ORM's RPC surface in Odoo 19 and is unnecessary on every version — update_list() commits server-side and the following search_count() is a fresh read — so removing it is version-safe AND avoids a wasted, always-failing round-trip on Odoo 19. Tests: update-list no longer calls clear_caches (assert_not_called); dropped the now-moot 'survives a raising clear_caches' test. Co-authored-by: bosd <5e2fd43-d292-4c90-9d1f-74ff3436329a@anonaddy.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #236.
fluvo module update-list404s on Odoo 19 becauserun_update_module_list()callsir.module.module.clear_caches()over RPC, and that method was removed from the ORM in Odoo 19 (cache handling is now internal / not RPC-exposed). This also cascades into aTypeErrorinmodule install.Fix: remove the
clear_caches()RPC call. It's unnecessary —update_list()scans and commits the app list server-side, and the followingsearch_count([])is a fresh RPC read that already reflects the updated state. Version-safe across Odoo releases (no method that only exists on some versions).Verified against Odoo 19 (json2s connector):
update-listpreviously 404'd onclear_caches; removing the call lets it complete.Note: the secondary
module installTypeError(module_manager.pylist-comprehension overread()results) is tracked in #236 and may warrant a follow-up once update-list is unblocked.