Repository navigation
verify-1.6.0-done: the parity verdict judges every owed cell, not one; ledger sync keeps a gone scope with open findings (L-R23) (stacked on #918) - #950
Merged
Conversation
…; ledger sync keeps a gone scope with open findings (L-R23) TODO l.2750 item 7: assert_parity_verdict refused only owed == 0, so the floor was ONE cell: a replay whose id filter kept 1 owed cell of 1,015 printed green, and the selftest pinned owed=913 of 2,318 as the green case. The verdict now takes owed-baseline.txt and cells.json and refuses unless totals.owed equals the golden's PASS count, totals.cells_in_scope equals the committed corpus, and owed + unbaselined closes the scope (the pinned engine's partition, busbar-release run.rs). RED selftest fixtures: one owed cell, all but one, a short corpus, an open partition, no baseline named. L-R23 (TODO l.4173): `cargo xtask ledger sync --write` dropped a scope whose path is gone together with its open HIGH/MEDIUM findings and exited 0. It now refuses (exit 1, nothing written) unless `--drop <id>` names each such scope, and refuses a --drop that names no gone open scope. RED: audit_cmd move_tests::sync_keeps_a_gone_scope_with_open_findings_unless_drop_names_it. The audit ledger rules step's declared count moves 27 -> 28 in the same commit (audit 11 + audit_cmd 12 + pinned 5). Stacked on #918 (row 90), which edits the same script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PROOF-INTEGRITY lane, PR-E. DRAFT, stacked on #918 (row 90 edits the same script; agreed with the row-90 lane). Retargets to predev once #918 lands (queue rule 19).
TODO l.2750 item 7 — the floor of one.
assert_parity_verdict(scripts/verify-1.6.0-done.sh:647-669 on predev) refused onlyowed == 0; its own selftest pinnedowed=913of 2,318 as GREEN. It now takestesting/shadow-oracle/owed-baseline.txtandtesting/shadow-oracle/cells.json(the committed files) and refuses unless:totals.owed== the golden's PASS count (1015 on predev; every one is in cells.json, measured),totals.cells_in_scope== |cells.json cells| (2518),owed + unbaselined == cells_in_scope(busbar-releaserun.rs:1770-1800partitions the selected cells exactly so).Unbaselined cells stay governed by
assert_golden_bookkeeping(named in accepted-gaps or rig-proven), unchanged. RED selftest fixtures: one owed cell judged, all but one, a short corpus, an open partition, no baseline named. Function exercised locally against all fixtures (shell only, no cargo).L-R23 (TODO l.4173).
cargo xtask ledger sync --writedropped a gone scope with open HIGH/MEDIUM findings and exited 0. It now refuses (exit 1, nothing written) unless--drop <id,..>names each such scope; a--dropnaming no gone open scope is refused too. RED:audit_cmd::move_tests::sync_keeps_a_gone_scope_with_open_findings_unless_drop_names_it. The audit-rules step count moves 27 -> 28 in the same commit (audit 11 + audit_cmd 12 + pinned 5).