Repository navigation
structure-lint roster: decisions is a kind-only plane key (vanished door row is PLANE-ROOT-MISSING) - #939
Merged
Conversation
…ished door row is PLANE-ROOT-MISSING The fifth plane (#48) is located only by its door row (`plane-decisions` on the plane-door axis) and was on neither roster list. So taking that axis off its row dropped the plane from structure-lint's plane roster with no finding, the silent-off-roster case the roster exists to refuse. - xtask/src/planes.rs PLANE_KEYS_KIND_ONLY = ["mcp", "decisions"], and its shell twin scripts/plane-keys.sh PLANE_KEYS_KIND_ONLY="mcp decisions" (pinned equal by xtask/tests/infra.rs). - RED: structure_lint selftest plants `plane-decisions = ""` in place of its plane-door axis and requires PLANE-ROOT-MISSING naming `decisions`. With decisions off the list the plane leaves the roster and the case fails. The shell list also feeds the report-only meters plane-grep-gate.sh and plane-noun-gate.sh. No CI step or xtask gate runs them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small fix from the streaming lane's finding. Not
$, and independent of #894.The
decisionsplane (#48) is located only by its door row (plane-decisionson theplane-dooraxis). It was on neither roster list, so if that row lost its axis, the plane dropped off structure-lint's plane roster with no finding.What
xtask/src/planes.rs:PLANE_KEYS_KIND_ONLY = ["mcp", "decisions"], plus its shell twinscripts/plane-keys.shPLANE_KEYS_KIND_ONLY="mcp decisions". The two are pinned equal byxtask/tests/infra.rs.plane-decisions = "plane-door"withplane-decisions = ""and requiresPLANE-ROOT-MISSINGnamingdecisions. With decisions off the list, the plane silently leaves the roster and the case fails.Overlap: #787 and #503 edit the same two lists. The final state is
PLANE_KEYS = ["llm"]andPLANE_KEYS_KIND_ONLY = ["mcp", "a2a", "streaming", "decisions"]; whoever lands second resolves.The shell list also feeds the report-only meters
plane-grep-gate.shandplane-noun-gate.sh. No CI step or xtask gate runs them.