Repository navigation
$ amend_rate_history: a signed correction applies once and is back-dated (TODO M28) - #938
Draft
MattJackson wants to merge 1 commit into
Draft
MattJackson wants to merge 1 commit into
MattJackson wants to merge 1 commit into
Conversation
…d (TODO M28) A signed amend_rate_history body could be replayed: the signature covers the window, figures and reason and nothing that tells one submission from the next, so the same bytes sent after a later correction put the earlier price back with no new operator act. And a correction could open in the future, standing in for a configuration write under an amendment's signature (#79: a correction is an entry whose effective_from lies in the past). - a correction the history already holds (same signer, reason, window, figures) is refused Conflict, checked under the apply lock ahead of the seal: nothing recorded, nothing appended - effective_from after the arrival is refused Validation - the #32 controls drop the future in-day window; the thousand-amendments volume cell signs a thousand different corrections - RED: a_future_dated_correction_is_refused_and_appends_nothing, a_replayed_signed_correction_is_refused_and_appends_nothing
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO M28 (docs/design/1.6.0-TODO.md:3827): a signed
amend_rate_historycan be REPLAYED and dated into the FUTURE.Fix (
crates/busbar/src/root/units_admin/mod.rs):Conflict(409); the check runs insideRootHistory::amend's apply lock, ahead of the journal seal, so nothing is recorded or appended. Re-asserting a price on purpose is a new correction with its own reason.effective_fromafter the arrival is refusedValidation(400). Spec 1.5.5 MCP: close the anonymous front door, and make the wire match the revision it claims #79 (BUSBAR-1.6.0.md:2282): a back-dated correction is "an entry whoseeffective_fromlies in the past"; a forward price is a configuration write.No 1.5.5 golden: D38
amend_rate_historyis 1.6.0-only (BUSBAR-1.6.0.md:2202). Ruling: owner 2026-10-14 queue rule 21.RED (
crates/busbar/src/root/units_admin/tests/units_admin.rs):a_future_dated_correction_is_refused_and_appends_nothing(whole future days and an in-day future window both applied before),a_replayed_signed_correction_is_refused_and_appends_nothing(the first body re-sent after a later correction applied before and repriced the window back). The #32 controls drop their future in-day window; the thousand-amendments volume cell signs a thousand different corrections (it re-sent one body, a replay).File overlap:
units_admin/tests/units_admin.rsis also edited by draft #870 (money-float, hunk at l.3902-3930); this PR's hunks are at l.4150-4260 and l.4380, textually disjoint.$PR: DRAFT per queue rule 15.