Repository navigation
$ teller: the exit spends the hold by the one figure it settles at (TODO L1689) - #929
Draft
MattJackson wants to merge 1 commit into
Draft
MattJackson wants to merge 1 commit into
MattJackson wants to merge 1 commit into
Conversation
…O L1689) The exit spent the hold by the run's AccrualMeter total and settled it by the settlement writer's amount. Two numbers: an end that settled 80 inside a reservation of 100 posted an OVERDRAFT of 50 the meter alone ran up, and the exit, the sweep and recovery disagreed on the overdraft figure. No production leg accrues onto the meter or offers headroom, so production postings are unchanged: the door reserves zero and children accrue zero, where both spellings give overdraft = settled - reserved. - exit: hold.spend(amount, 0); offer_headroom/headroom deleted (no caller) - root harness records the posting's settled figure, not the meter - RED: loop_battery the_hold_is_spent_by_the_figure_it_settles_at_not_by_a_second_count (meter 150, reported 80, reserved 100: overdraft 50 before, 0 after)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO L1689-1692 (docs/design/1.6.0-TODO.md):
crates/busbar-kernel/src/teller.rsexit spent the hold byrun.meter.total()and settled it by the settlement writer'samount.Fix:
hold.spend(amount, 0)— one figure spends and settles the hold.AccrualMeter::offer_headroom/headroomdeleted (no caller anywhere). The root test harness records the posting's settled figure instead of the meter.Production postings are unchanged: no production leg accrues onto the meter (only
busbar-kernel/tests/common/mod.rs:497), the root door reserves zero (crates/busbar/src/root/door_steps.rs"The door reserves nothing") and children accrue zero, so both spellings giveoverdraft = settled - reserved. Ruling: owner 2026-10-14 queue rule 21 ("money - ledger * ratecard").RED:
crates/busbar-kernel/tests/loop_battery.rsthe_hold_is_spent_by_the_figure_it_settles_at_not_by_a_second_count— meter 150, reported 80, reserved 100: posted overdraft 50 + OVERDRAFT flag before, 0 after.Remaining:
AccrualMeter/Run.meterare now test-rig only; deleting them touches files open PRs edit (#787 kernel tests/common, #923 root plane_node.rs, #902/#870, #912/#824, #778/#561) — follow-up once those land.$PR: DRAFT per queue rule 15.