Repository navigation
contract: strike the stale export_door! rename note (row 84, S0; stacked on #904) - #928
Merged
Merged
Conversation
…ut of the condemned HOT lane into abi/shared.rs (row 84) Status row 84 (old plugin interface gone; THE DESIGN §11: the plugin ABI is the memory ABI alone). DeclStr, WireConnFacts, WireField and the closed-vocabulary byte codes (code) are the shapes abi/host/conn (the memory ABI's connection table) carries; they were defined in abi/hot/decl.rs and abi/hot/transport.rs. They move whole, unchanged, to their one home under abi/ (abi/shared.rs); the HOT lane names them through re-exports until it is deleted, so every user (the connection table, the HOT transport load path, the layout golden) resolves the same types at the same paths and no layout moves. abi/hot: 6224 -> 5965 lines (qa/abi-freeze.toml lowered in this commit, the freeze is exact); non-test 5177 -> 4918. abi/shared.rs is outside the C header's sources, so the header is unchanged.
…ventory, PluginInfo) is deleted; it had no caller (row 84) Status row 84 (old plugin interface gone). validate_plugin and inventory dlopen'd a library and checked the COLD/JSON lane's symbols (busbar_open, busbar_call, busbar_free, busbar_close); nothing calls either outside their own tests: the admin surface lists tarballs through registry::inventory (inventory_tarballs) and vets uploads by filename, and every plugin loads through its door (dispatch::load). They go, with PluginInfo, validate_mapped and their tests; plugin-loader no longer names the cold lane's open/call/free/close types or symbols. The behaviour the deleted vet asserted stays tested where it lives: a door-less library that states a JSON-contract kind is refused by the kind read (read_plugin_kind), naming the missing door, the kind and the rebuild (lib_tests: a_door_less_json_contract_library_is_refused_naming_ the_rebuild, RED against a read that takes the kind symbol on its word); the routed unload stays pinned by ffi_guard_tests (dlclose_on_worker_routes_the_unload_and_counts_it).
…e handshake the loader still reads (row 84)
No plugin of any kind rides the COLD/JSON lane. Its SDK half had no live user:
- sdk/mod.rs: export_plugin!, the ColdEntry re-export, Door::Cold / cold(), the hostlog bridge, the
busbar_set_log_sink / busbar_open / busbar_call / busbar_free / busbar_close exports and their
Symbols fields, the BoundaryOutcome re-export and the in-file test module are gone. The door
handshake (busbar_abi, busbar_plugin_kind, the plane and transport decls, busbar_plane_arm) stays.
- sdk/boundary.rs keeps only `caught`, the one catch_unwind the connection table and the transport
slots cross. The cold open/call/free/close bodies are gone.
- abi/cold/mod.rs: 272 -> 43 lines. It keeps TRANSPORT_VERSION, symbol::{ABI, PLUGIN_KIND}, AbiFn
and PluginKindFn, which plugin-loader's handshake (abi_symbol, abi_handshake, read_plugin_kind)
still reads until the HOT lane goes.
- Tests: sdk/tests/lib_tests.rs, cold/tests/lib_tests.rs, tests/one_door.rs and
tests/boundary_class.rs exercised only the deleted cold symbols. one_link_many_plugins.rs now
links two export_transport! doors and proves each linked door is its own plugin. The busbar_open
assertions in it and in one_transport_door.rs are gone with the symbol.
- choke row B-plugin-export is re-pointed at sdk_door_cdylib.rs's panic->FAULT test (the
single-export test sits beside it), and docs/testing.md follows.
- The ffi_thread.rs and observe.rs docs no longer name the deleted symbols.
Ledgers: qa/abi-freeze.toml cold 272 -> 43 (exact). In qa/one-memory-abi.toml the eight findings
whose code is gone are struck: boundary.rs abi::cold; sdk/mod.rs ColdEntry and busbar_call
(cold-lane); and the busbar_call, busbar_close, busbar_free, busbar_open and busbar_set_log_sink
exported-symbol rows.
…s deleted and there is no fleet rename (ARCHITECT, row 84)
…he stubs moved to (#898, row 84) #898 moved DeclStr out of hot/decl.rs into abi/shared.rs, so every marker below it moved up 36 lines. The gate's own lists name the move: 8 unwaived (427, 439, 446, 450, 454, 472, 481, 497) and 8 stale (475, 482, 486, 499, 508, 517, 526, 533). The other two markers (admin_routes, admission) landed on 463 and 490, lines that two older rows already named, so those rows matched by accident. Each row moves by the same 36 lines and keeps its own reason: 463->427 (the STUB doc label), 475->439, 482->446, 486->450, 490->454, 499->463, 508->472, 517->481, 526->490, 533->497. Every new line was read against the file: it holds the marker its row names.
… into lane-abi-cold-sdk
…ber (#898, row 84) feature_invariance::the_doc_comments_cite_the_design_in_words refused shared.rs:7, which pointed at the plugin-ABI section of THE DESIGN by its number. It now names it in words: "THE DESIGN, the plugin ABI", the spelling abi/mod.rs and mechanism/observe.rs use.
…nto lane-abi-cold-sdk
…rides with it This head carries #904's fixes for its own reds: - the #898 no-deferral waiver re-key and its in-words design citation; - kind-isolation busbar-contract x instance:secret lowered 133 -> 131 (the drain the gate measured); - the contract-stateless strike of the four drained SDK statics. qa/abi-freeze.toml conflicted on the abi/hot row. Base 6224; predev 6100 (its own hot drains in services.rs and host.rs); this branch 5965 (#898's move to abi/shared.rs). The two drains touch different files, so both apply: 6100 + 5965 - 6224 = 5841, the same settle #898 took. The merged tree measures that exactly, every line of every file under abi/hot counted by hand (no xtask on the laptop). The cold row stays at this branch's 43, also counted on the merged tree; predev did not touch abi/cold.
…nto lane-abi-next
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Row 84, S0. This is stacked on #904 and stays a DRAFT until #904 lands (rule 19).
sdk/door.rs:797said to renameexport_door!toexport_plugin!once the cold macro was deleted. #904 deletes that macro. The ARCHITECT ruled out a fleet-wide rename, so this PR strikes the note.This is one deleted comment line. No code changes.