Repository navigation
row 159: audit ledger records the secret-file declares reading (stacked on #845) - #915
Open
MattJackson wants to merge 1 commit into
Open
MattJackson wants to merge 1 commit into
MattJackson wants to merge 1 commit into
Conversation
…ited pinned scope (row 159) crates/busbar-secret-file/declares.json, round 1 at 00555bd: zero. The document states only the superseded contract range {2,2}. That is the secret kind's one version at the shipping host (busbar-contract abi/secret/mod.rs:40) and at the plugin's pinned host c4d7254, whose sign.rs:886 range check admits it. The shipping loader no longer reads the range (plugin-loader sign.rs:300-305). The source's Statement (secret-file/src/door.rs:41-44) names no need, and the plugin declares no metric or diagnostic. The tree_hash was recomputed with the pinned plugin mounted from Cargo.lock (secret-file 479c833a10, the same pin on predev).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes only the ledger (
qa/audit-ledger.json). It is stacked on #845, which carries #835 and #820, so it holds their commits.What. One new round for
crates/busbar-secret-file/declares.json, round 1 at 00555bd (an ancestor of predev), result zero. #820 recorded the other declares documents, and this one was stillunauditedafter #845.What the reading found:
{"contract_abi": {"min": 2, "max": 2}}, the pin is busbar-secret-file 479c833a10, and the pin is the same on predev 1d37d86.crates/plugin-loader/src/sign.rs:300-305,:990).crates/busbar-contract/src/abi/secret/mod.rs:40) and the plugin's own pinned host c4d7254. The pinned host's pack check (sign.rs:886-905there) admits it. This differs from secret-env's document, which declares 1 and carries a MEDIUM.secret-file/src/door.rs:41-44) names no transport need, and the plugin declares no metric or diagnostic, so nothing is missing.The
tree_hashwas recomputed at 00555bd with the pinned plugin mounted fromCargo.lock, the same wayxtask/src/audit.rs/audit_pinned.rsdo it. As a check, the same tool reproduces the recorded hashes of the sibling secret-env and transport-tcp declares scopes.Why. /status row 159 needs 0 unaudited production scopes. After #820, #835, #845 and this PR, three scopes remain unaudited:
crates/busbar-a2a/src,crates/busbar-llm/srcandcrates/busbar-voice/src. Per the ARCHITECT ruling, each leaves with its deletion PR (#787, row 155, #503).RED-able. No code changes. On ModernCI,
cargo xtask ledger --checkchecks the new round:stampedif the hash is not the tree ataudited_at,unreachableif the commit is not an ancestor.