Skip to content

P5: busbar-transport-stdio leaves for its own repo, pinned (/status row 158) - #901

Open
MattJackson wants to merge 2 commits into
predevfrom
lane-p5-extract-transport-stdio
Open

MattJackson wants to merge 2 commits into
predevfrom
lane-p5-extract-transport-stdio

Conversation

@MattJackson

Copy link
Copy Markdown
Collaborator

/status row 158: extract busbar-transport-stdio to its own repo and pin it. Crates go 24 -> 23. Not $.

Spec:

It uses the same pattern as tcp, http, ws and store-memory (#783).

Based on predev, not on #561. The only stdio coupling #561 has is two TransportTail fields in src/meta.rs (fault_rows, fault_rows_len). #778/#787 carry the same hunk. So #561 needs a stdio pin the same way it already pins tcp, ws, http and grpc (p2-breaker-neutral-ts-pin); it no longer needs an in-tree edit. #561 is a conflicting draft, and stacking this on it would hold row 158 behind it.

What

  • crates/busbar-transport-stdio is deleted. repin: busbar 5c99befcfa; busbar deletes its in-tree stdio crate and pins this repo (P5, row 158) busbar-transport-stdio#14 (CI green) carries it at busbar pin 5c99befcfa.
    • It is byte for byte, except that lib.rs uses the twin layout: the cdylib export is in transport-stdio-plugin, not behind dropped-in.
    • The root pins its head 604a5caf13 with one git row.
  • The root's edge takes the workspace row. Its transport-stdio linked and linked-axes rows are unchanged.
  • deny.toml: allow-git gains the repo.
  • plugins.yaml: drops pending_crate.
  • Cargo.lock: the package resolves from git. busbar-contract stays patched to the path crate.

Selftests

  • linked-dropped-features and plugin-closure-deps scan workspace members only. Their plants move from the stdio crate to busbar-transport-webrtc, the one transport still in crates/.
  • kind-isolation's plants keep their crates/busbar-transport-stdio paths. The gate lays every pinned plugin-kind checkout at crates/<package> beneath its overlay (kind_isolation/pinned.rs), as it does for tcp, http and ws.

Ledgers

Conflicts (merge-tree against open PRs)

…o; the root pins it (/status row 158)

BUSBAR-1.6.0.md l.2220 (#39): "plugin SOURCE never re-enters busbar". l.3962: each plugin crate is
pinned back as a git dependency in the root manifest's linked rows. This uses the tcp/http/ws/
store-memory pattern. Crates go 24 -> 23.

- crates/busbar-transport-stdio is deleted. GetBusbar/busbar-transport-stdio#14 carries it, byte for
  byte except the twin layout of lib.rs (the cdylib export is in transport-stdio-plugin), at busbar
  pin 5c99bef. The root pins that PR's head 604a5caf13 with one git row. The root's edge takes
  the workspace row, and its `transport-stdio` linked row is unchanged.
- deny.toml allow-git gains the repo; plugins.yaml drops pending_crate. Cargo.lock: the package
  resolves from git, and busbar-contract stays patched to the path crate.
- Selftests that planted into the in-tree stdio crate:
  - linked-dropped-features and plugin-closure-deps scan workspace members only, so their plants
    move to busbar-transport-webrtc, the one transport still in crates/.
  - kind-isolation's plants keep their paths: the gate lays every pinned plugin-kind checkout at
    crates/<package> beneath its overlay (kind_isolation/pinned.rs), as for tcp, http and ws.
- Ledgers:
  - qa/construction.toml drops the manifest-allowlist row for a manifest no longer in crates/, as
    the ws extraction did.
  - The census floor `transport = 1` holds: webrtc.
  - Kept rows, each still measured from the pinned checkout: kind-isolation's stdio cell and
    root edge, the dep-wall carrier exemption (the crate still resolves) and the audit-ledger
    scopes (#589 reads pinned plugin scopes from the checkout).
- crates/busbar-kernel/Cargo.toml: a comment's example of a self-naming crate is now webrtc. The
  hit count is unchanged.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant