Repository navigation
tests: child halves and an opt-in measurement no longer pass by returning (row 114, 2/2) - #889
Merged
Merged
Conversation
…ning (row 114)
restart_phase (durability_amend.rs), node_boot_hooks_arm (serve_money.rs) and
panic_child (plugin-loader dispatch_tests.rs) each returned early when their
parent's variable was unset, so the default run counted three passes that
proved nothing. Each is now #[ignore = child process of <parent>], fails by
name when run without its parent, and its parent runs it with --ignored (the
pattern loader_seam_tests' foreign_panic_child already uses). The parents
already assert the child ran ("1 passed" / a non-success abort), so a child
that stops running fails its parent.
capture_latency_metrics (busbar-llm) was an env-gated no-op passing in 0s: it
is #[ignore = a measurement] and runs whenever asked with --ignored.
The two bare #[ignore] benches (busbar-plane-llm same_proto_fidelity_tests,
busbar-kernel store tests) state their reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status row 114 (no test in crates/ passes by an early-return skip when its subject is absent in the default build). Part 2 of 2. Part 1 is #887 (the conformance suite).
Child halves: the default run counted these as passes, but each one only returned because its parent's variable was unset:
crates/busbar/src/root/tests/durability_amend.rsrestart_phase(let-else on PHASE/DIR → return)crates/busbar/src/root/tests/serve_money.rsnode_boot_hooks_arm(if var_os(NODE_HOOKS_ARM).is_none() { return; })crates/plugin-loader/src/tests/dispatch_tests.rspanic_child(let-else on BUSBAR_M1_PANIC_CHILD → return)Each one now has
#[ignore = "child process of <parent> ..."], fails by name when run without its parent, and its parent runs it with--ignored. This is the patternloader_seam_tests::foreign_panic_childalready uses. Proof that the wiring holds: each parent already asserts that its child ran.run_phaseand the node-hooks parent require "1 passed", and the abort parent requires a SIGABRT, so a child that stops running turns its parent red.Opt-in measurement:
crates/busbar-llm/src/engine/tests/forward_pool_integration_tests.rscapture_latency_metricswas a no-op gated onBUSBAR_CAPTURE_METRICSand passed in 0s. It is now#[ignore = "a measurement ..."]and runs whenever someone asks with--ignored. The crate is still on predev; row 155 deletes it.Reasons stated: the two bare
#[ignore]timing benches (busbar-plane-llmbench_same_proto_short_circuit,busbar-kernelbench_select_weighted_in_seam).No test removed (BUSBAR-1.6.0.md l.1182, F25). Law 0 (l.2038): a test that cannot produce a NO is not a check.
No file here is held by another open PR. Sweep evidence: /Users/matthew/Developer/tmp/lane114/skips.tsv. No cargo was run locally; ModernCI's verdict is the proof.