Repository navigation
llm codec tests: F25 REHOME rows 108, 110, 350, 504, 505, 613, 614 - #883
Merged
Merged
Conversation
…rted to their codec homes Each legacy busbar-llm engine test is ported at equal strength (its literal figures) onto the served codec path its F25 v2 row names: Bedrock tool_choice none forwards and reports the drop (108); a native-structured-output Anthropic lane rides output_config.format and reports a schema-less json_object (110); an Anthropic tool id reaches an OpenAI client remapped and unleaked (350); the router shim keys strip per egress and the model survives strip-then-rewrite, with the same-dialect relay sending the caller bytes (504, 505); the Cohere stop-sequence cap clamps six to five and forwards five whole (613, 614).
Collaborator
Author
|
Rule 20 note from #1031 (row 155, draft): one disjoint hunk in stream_translate_tests.rs (synthesize_from_response takes the cap). A test merge is clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What. These F25 coverage-map v2 REHOME rows have their home under
busbar-plane-llm/src/codec/**. Each legacycrates/busbar-llm/src/engine/tests/*test is ported at equal strength: the same inputs, the same literal figures, and no circular check. The assertions run on the served codec path the row names.egress_dropped_controls_audit_tests.rs:89bedrock/tests/tests.rs::openai_tool_choice_none_onto_bedrock_forwards_and_reports_the_drop: non-empty body,get_weatherkept,toolChoiceomitted,tool_choice=nonein dropped controlsegress_dropped_controls_audit_tests.rs:245anthropic/tests/ir_mapping_q57_tests.rs::native_structured_output_lane_drops_schema_less_json_and_reports_itingress_indistinguishability_tests.rs:2234tests/proto/stream_translate_tests.rs::an_anthropic_tool_call_id_reaches_an_openai_client_remapped_and_unleaked:call_…, nottoolu_origRAW123, raw id absent from the body, decodes backmid_stream_error_tests.rs:294tests/wire_shim_tests.rs::strip_router_shim_keys_removes_the_never_native_keys_per_egressmid_stream_error_tests.rs:337tests/wire_shim_tests.rs::shim_strip_then_rewrite_model_keeps_the_model_cross_protocol(plus the same-dialect relay byte check)stop_sequence_cap_degrade_tests.rs:23tests/proto/response_format_matrix_tests.rs::openai_to_cohere_over_cap_stop_sequences_are_clamped_not_rejected: six become[a..e]stop_sequence_cap_degrade_tests.rs:63…::openai_to_cohere_exactly_cap_stop_sequences_are_forwarded_wholeFor rows 108 and 110, the legacy audit row (
egress.control_unrepresentable) is fed by the dropped-control name, so the codec-level port pins that name. That is the "or dropped_egress_controls contains it" the row allows.Rows 107 and 109 are in a separate PR stacked on #857, because #857 restores 1.5.5's
response_formatdrop on Anthropic. Tests only; not$.