Repository navigation
row 113: admin DR verbs proven to land on the book's configured store (test-only; wiring landed in #556) - #817
Open
MattJackson wants to merge 1 commit into
Open
MattJackson wants to merge 1 commit into
MattJackson wants to merge 1 commit into
Conversation
…y recovery verb and the replay slot (RED: units holding no store, or any other store, fail it)
Collaborator
Author
|
FYI (queue rule 20): $ draft #870 also edits crates/busbar/src/root/tests/kernel.rs (l.204-209, l.614-620: RawTierRates fixtures go through representable_nano_rate); disjoint from your l.408 block, merges clean. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Row: /status 113 — admin DR verbs reach the configured store on predev; RefusingStore/StoreRef gone.
What. The wiring landed in #556 (5d279a5, 2026-10-07): boot binds the loader's adapter over the configured store onto the node's book (
root/boot.rsverb_store: Some(adapter.verb_store())),maincomposes the admin units over that book (ProductionUnits::admin_over_book), androutehandsunits.storetobusbar_core_admin::Verbs. The root'sRefusingStoreandStoreRefare deleted. This PR adds one test only:root/tests/kernel.rsthe_admin_units_over_a_book_reach_that_books_store_for_every_recovery_verb.Why. The booted cell from #556 (
a_booted_nodes_recovery_verbs_reach_its_configured_store_through_the_book) goes RED when a verb is REFUSED. It stays green if the units hold a different store that also answers Ok. The new test puts a recording store on the book, composes the units throughadmin_over_book, drives chain_break, store_restore("nightly"), reseal_epoch_floor and the replay slot (commit, then read) through the units' handle, and asserts that each one, with its arguments, lands on THAT store in order. THE DESIGN: the store is reached through the loader adapter (busbar_contract::verb_store::Store). No new seam or ABI.RED-able. Units with no store fail the
expect. Units with any other store leave the recording log empty, so theassert_eqfails.Ledgers touched: none. Test-only. 1.5.5 admin behaviour is unchanged.
Residual grep hit:
git grep 'RefusingStore\|StoreRef' origin/predev -- cratesnow returns only a test-local fault double inbusbar-a2a/src/a2a/tests/taskstore_tests.rs(a full-disk store for the a2a task registry, not related to admin). #787 deletes busbar-a2a, so this PR does not touch it (rule 4.2).