Skip to content

no-silent-skip sweep (status row 114): scrape-sink test gated on its feature - #816

Merged
MattJackson merged 3 commits into
predevfrom
lane-no-silent-skip
Oct 13, 2026
Merged

MattJackson merged 3 commits into
predevfrom
lane-no-silent-skip

Conversation

@MattJackson

@MattJackson MattJackson commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Status row 114: no test in crates/ passes by an early-return skip when its subject is absent in the default build.

Sweep: every #[test]/#[tokio::test] body scanned for early return, plus eprintln!("skip..."), var("CI") and env opt-outs. Most of the tree was already clean (the per-crate no_silent_skip scans exist in busbar, busbar-kernel, busbar-core-admin, plugin-loader).

Changed (the site is in files no open PR touches):

  • crates/busbar/src/root/tests/linked.rs:561 (the_linked_scrape_sink_renders_the_recorder_snapshot_byte_identically): if module.is_empty() || registry.resolve(module).is_none() { return; }. The sink is linked by default feature export-prometheus (case b): the test is now #[cfg(feature = "export-prometheus")] and the guard is two asserts, so an absent sink fails loudly.

Left: crates/busbar-llm forward_pool_integration_tests.rs:60 (capture_latency_metrics env opt-in) because row 155 deletes the crate.

Found but NOT changed, because an open PR touches the file:

Reviewed and left: crates/plugin-loader/src/conformance/mod.rs:1879 (needs_declared, no declares.json; plugin-ci owns presence, helper not a test); re-exec child-process guards (durability_amend.rs:78, serve_money.rs:663/688, loader_seam_tests.rs:144, dispatch_tests.rs:1560, stage_tests.rs:356) which are the parent/child halves of one test, not skips; retry/accept-loop and walker filters.

RED-able: removing the sink from the linked rows now fails the scrape test instead of passing.
No cargo run locally (rules); ModernCI is the proof.

@MattJackson MattJackson changed the title no-silent-skip sweep (status row 114): scrape-sink test gated, latency capture ignored no-silent-skip sweep (status row 114): scrape-sink test gated on its feature Oct 13, 2026
…cfg, naming no export instance (law0 busbar x export stays 15)
@MattJackson
MattJackson merged commit 91f44b0 into predev Oct 13, 2026
1 check passed
@MattJackson
MattJackson deleted the lane-no-silent-skip branch October 13, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant