Repository navigation
no-silent-skip sweep (status row 114): scrape-sink test gated on its feature - #816
Merged
Merged
Conversation
…its feature, the latency capture is #[ignore] instead of a silent pass
…cfg, naming no export instance (law0 busbar x export stays 15)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status row 114: no test in crates/ passes by an early-return skip when its subject is absent in the default build.
Sweep: every
#[test]/#[tokio::test]body scanned for earlyreturn, pluseprintln!("skip..."),var("CI")and env opt-outs. Most of the tree was already clean (the per-crateno_silent_skipscans exist in busbar, busbar-kernel, busbar-core-admin, plugin-loader).Changed (the site is in files no open PR touches):
the_linked_scrape_sink_renders_the_recorder_snapshot_byte_identically):if module.is_empty() || registry.resolve(module).is_none() { return; }. The sink is linked by default featureexport-prometheus(case b): the test is now#[cfg(feature = "export-prometheus")]and the guard is two asserts, so an absent sink fails loudly.Left: crates/busbar-llm forward_pool_integration_tests.rs:60 (
capture_latency_metricsenv opt-in) because row 155 deletes the crate.Found but NOT changed, because an open PR touches the file:
Reviewed and left: crates/plugin-loader/src/conformance/mod.rs:1879 (
needs_declared, no declares.json; plugin-ci owns presence, helper not a test); re-exec child-process guards (durability_amend.rs:78, serve_money.rs:663/688, loader_seam_tests.rs:144, dispatch_tests.rs:1560, stage_tests.rs:356) which are the parent/child halves of one test, not skips; retry/accept-loop and walker filters.RED-able: removing the sink from the linked rows now fails the scrape test instead of passing.
No cargo run locally (rules); ModernCI is the proof.