Skip to content

c1-literals: the browser-login button brands are the root legacy table's frozen 1.5.5 rows - #1043

Merged
MattJackson merged 1 commit into
predevfrom
lane-c1-brand
Oct 15, 2026
Merged

MattJackson merged 1 commit into
predevfrom
lane-c1-brand

Conversation

@MattJackson

Copy link
Copy Markdown
Collaborator

Drains the c1-literals row crates/busbar-kernel/src/auth/token.rs | github and busbar-kernel × law0 instance:auth 8 → 5. This follows the coordinator's ruling (c): the brands become root legacy-table data.

What changes

  • Brands become a legacy row. The kernel's /auth/token chooser inferred three provider brands (label and icon) from the method name and OIDC issuer host, with the brand words spelled in kernel source. Those are frozen 1.5.5 login-page data (v1.5.5 crates/busbar/src/auth/token.rs:1073-1112). They are now:

    • one row in the root legacy table, plugins.yaml legacy: login_brands;
    • rendered into [package.metadata.busbar.legacy];
    • mirrored in the kernel test stand-in;
    • handed in with the rest of LEGACY_ROWS.

    This is the mechanism KN-2c/2d: recorder log line is a frozen root legacy row; kernel diagnostics name no sink or auth plugin (Law 0) #987 also uses; there is no second loader. Each brand is <match tokens> : <label> : <icon ref>, in 1.5.5's match order.

  • The kernel matches generically. It matches each method against the handed row. A method that matches nothing, or a build with no row, gets its title-cased name under the generic icon, as before.

  • The SVGs stay as plain assets. The three brand SVGs are keyed by icon ref and contain no plugin word. A diff of the brand block against v1.5.5 showed it identical, so the bytes are verbatim.

  • No seam is touched. The oauth_as seam and core-oauth2 are unchanged.

  • The chooser test names no brand any more: github became second-sso.

Bytes

The shipped binary renders the same HTML, because the root installs the table before any config is read.

RED

the_button_brands_are_the_legacy_row_and_with_no_row_every_method_is_generic:

  • With the row, each brand's first token renders that brand's label and icon on the chooser button.
  • The issuer host matches the same way the name does.
  • An unmatched method renders the generic arm.
  • With no row, every brand token renders the generic arm.

Merge safety

Nothing was run locally; CI is the proof.

…e's frozen 1.5.5 rows

The kernel's /auth/token chooser inferred three provider brands (label + icon) from the method
name and OIDC issuer host with the brand words spelled in its source. They are frozen 1.5.5
login-page data (v1.5.5 crates/busbar/src/auth/token.rs:1073-1112), so they move into the root
legacy table: plugins.yaml `legacy: login_brands` (rendered into
[package.metadata.busbar.legacy], mirrored in the kernel test stand-in), one row
`<match tokens> : <label> : <icon ref>` per brand in 1.5.5's match order, handed to the kernel
with the rest of LEGACY_ROWS. The kernel matches each method generically against the handed row;
no match, or no row, is the title-cased name under the generic icon, as before. The three brand
SVGs stay as plain assets keyed by icon ref (verbatim from 1.5.5, checked by diff). Same bytes on
the shipped binary; no seam is touched.

RED: the_button_brands_are_the_legacy_row_and_with_no_row_every_method_is_generic.
c1-literals row (auth/token.rs github) struck; law0 busbar-kernel instance:auth 8 -> 5.
@MattJackson
MattJackson merged commit 7749459 into predev Oct 15, 2026
1 check was pending
@MattJackson
MattJackson deleted the lane-c1-brand branch October 15, 2026 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant