Repository navigation
c1-literals: the browser-login button brands are the root legacy table's frozen 1.5.5 rows - #1043
Merged
Merged
Conversation
…e's frozen 1.5.5 rows The kernel's /auth/token chooser inferred three provider brands (label + icon) from the method name and OIDC issuer host with the brand words spelled in its source. They are frozen 1.5.5 login-page data (v1.5.5 crates/busbar/src/auth/token.rs:1073-1112), so they move into the root legacy table: plugins.yaml `legacy: login_brands` (rendered into [package.metadata.busbar.legacy], mirrored in the kernel test stand-in), one row `<match tokens> : <label> : <icon ref>` per brand in 1.5.5's match order, handed to the kernel with the rest of LEGACY_ROWS. The kernel matches each method generically against the handed row; no match, or no row, is the title-cased name under the generic icon, as before. The three brand SVGs stay as plain assets keyed by icon ref (verbatim from 1.5.5, checked by diff). Same bytes on the shipped binary; no seam is touched. RED: the_button_brands_are_the_legacy_row_and_with_no_row_every_method_is_generic. c1-literals row (auth/token.rs github) struck; law0 busbar-kernel instance:auth 8 -> 5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drains the c1-literals row
crates/busbar-kernel/src/auth/token.rs | githuband busbar-kernel × law0 instance:auth 8 → 5. This follows the coordinator's ruling (c): the brands become root legacy-table data.What changes
Brands become a legacy row. The kernel's
/auth/tokenchooser inferred three provider brands (label and icon) from the method name and OIDC issuer host, with the brand words spelled in kernel source. Those are frozen 1.5.5 login-page data (v1.5.5crates/busbar/src/auth/token.rs:1073-1112). They are now:plugins.yaml legacy: login_brands;[package.metadata.busbar.legacy];LEGACY_ROWS.This is the mechanism KN-2c/2d: recorder log line is a frozen root legacy row; kernel diagnostics name no sink or auth plugin (Law 0) #987 also uses; there is no second loader. Each brand is
<match tokens> : <label> : <icon ref>, in 1.5.5's match order.The kernel matches generically. It matches each method against the handed row. A method that matches nothing, or a build with no row, gets its title-cased name under the generic icon, as before.
The SVGs stay as plain assets. The three brand SVGs are keyed by icon ref and contain no plugin word. A diff of the brand block against
v1.5.5showed it identical, so the bytes are verbatim.No seam is touched. The oauth_as seam and core-oauth2 are unchanged.
The chooser test names no brand any more:
githubbecamesecond-sso.Bytes
The shipped binary renders the same HTML, because the root installs the table before any config is read.
RED
the_button_brands_are_the_legacy_row_and_with_no_row_every_method_is_generic:Merge safety
plugins.yaml,Cargo.tomland the fixture: my hunks are disjoint from KN-2c/2d: recorder log line is a frozen root legacy row; kernel diagnostics name no sink or auth plugin (Law 0) #987's rows. Itssnapshot_recorder_failedlands at fixture line 28 and Cargo line 728; mine land at fixture line 26 and Cargo line 716.token.rs: disjoint from contract: Redacted<T> becomes the sealed Secret<T>; expose(&impl KernelSeal) is the one accessor (#54; stacked on #927+#941) #1021, auth: the mint ceiling binds the self-serve mint (X-1001) #945 and row 166 PR1: secret resolve takes a config-time proof (ConfigScope) and the config-scope gate #863.Nothing was run locally; CI is the proof.