Repository navigation
egress seams: HOSTLESS moves onto the plane's build context (EGRESS_TRUST measured, not moved) - #1022
Open
MattJackson wants to merge 1 commit into
Open
MattJackson wants to merge 1 commit into
MattJackson wants to merge 1 commit into
Conversation
…xt, not a process static The HOSTLESS static (crates/busbar-kernel/src/egress/seam.rs), its installer install_hostless_egress and its reader hostless() are deleted. The one production reader was the A2A plane's ReqwestTransport (send_pinned_buffered / send_pinned_stream). The value now rides the handle that plane is already built from: - BuildCtx gains `hostless: EgressDriver`; the App build fills it with EgressDriver::core() (core's CoreHostlessEgress where the egress seam is compiled). - A2aPlane holds the driver it was built with; its relay bundle, the boot-built card transports (a2a_start) and an operator verb's probe (verbs::look) all take it from the plane. ReqwestTransport carries it and hands it to send_pinned_*, which now take the driver as an argument. - The root's register_seams and the test kit's install_root_egress no longer bind it. qa/door-only.toml: the door-only:static-seam row for egress/seam.rs HOSTLESS is struck. RED: each_plane_relays_on_the_driver_its_own_build_was_handed builds two planes over two driver doubles in one process; each plane's unary and streamed hop answers with its own driver's value, which the deleted first-install-wins static could not give.
Collaborator
Author
|
Rule 20 note from #1031 (row 155, draft): disjoint hunks in root/linked.rs (hot_answer_inline's cap reads busbar_kernel::proxy::max_translate_body_bytes) and root/tests/door_steps.rs (one test appended). A test merge is clean. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two process-global egress seams were in scope:
HOSTLESS(egress/seam.rs) andEGRESS_TRUST(egress/trust/mod.rs). This PR removesHOSTLESS.EGRESS_TRUSTis unchanged here. Its shape is given below.HOSTLESS: removed
Readers.
seam::hostless()had one production reader:send_pinned_buffered/send_pinned_stream, which are called only by the A2A plane'sReqwestTransport(execute,post_stream). That transport is built in three places:buildhook (from_config_carrying, the relay bundle)a2a_start(the boot-built per-agent card transports)verbs::look(an operator verb's probe)All three are built from the plane.
Handle.
BuildCtxgainshostless: EgressDriver. The App build fills it withEgressDriver::core(), which is core'sCoreHostlessEgresswhere the egress seam is compiled.A2aPlanestores the driver it was built with.LiveCardFetch::new/presentingandReqwestTransport::drivingcarry it to each transport, andsend_pinned_*take it as an argument. The static,install_hostless_egress,hostless(), the root'sregister_seamsinstall and the test kit'sinstall_root_egressare deleted. LiteralBuildCtxtest sites stateDefault::default(); the busbar integration tests that build real planes stateEgressDriver::core(). A transport that a2a's own unit test builds bare runs on the core driver (tests/egress_boot.rs), which is what the old test-only install gave it.Ledger. In
qa/door-only.toml, thedoor-only:static-seamrow forcrates/busbar-kernel/src/egress/seam.rs/HOSTLESSis struck.RED.
a2a/tests/egress_seam_tests.rs::each_plane_relays_on_the_driver_its_own_build_was_handedbuilds two planes in one process over two driver doubles (201 / 202). Each plane's unary and streamed hop answers with its own driver's value. Under the first-install-wins static, both planes read the same driver.The
linked_egresscfg is still emitted bylinked_gen(and its test still expects it), but the root no longer binds anything under it.EGRESS_TRUST: not moved, still a static
Moving it is well over the size budget, and several readers have no handle that carries the value today:
secure::layer()is read by the engine client build (engine/mod.rsspec.tls.or_else),ClientIdentity::from_pem(called at a2a config resolve) and the duplexwssdial.InstalledResolveris read by the duplex dial and the plane_host FFI egress open (plane_host/egress.rs, which row 74 F25: the door path's jwt-bearer mint keeps 1.5.5's raw aud, the stripped dial and the Basic #922 also edits).destinations_appliedis called fromappbuild.rsInstalledLimits::keep(edited by row 130 E6: the plugins.fetch download leaves busbar-kernel and rides the one connector (stacked on #804) #805 and row 74 F25: the door path's jwt-bearer mint keeps 1.5.5's raw aud, the stripped dial and the Basic #922).judged/judged_name/judged_answerserve everyEngineSpec::pooled_webpkiclient: busbar-llm build_runtime/tables, busbar-voice mount, and kernel preflight (preflight is edited by row 130 E6: the plugins.fetch download leaves busbar-kernel and rides the one connector (stacked on #804) #805).EngineSpecalready hasjudge/tls/dnsfields, so the move is to make every spec constructor take the trust handle from its caller. The root installs the value after config load, so it would ride the App build input. That touches about 45 EngineSpec test sites and hunks that #805/#922 also edit. The ledger row itself names the plan: "struck when D1-D6 move onto conns (Phase B)".