Repository navigation
test_support: delete the never-filled section-plane runtime factory seam (door-only) - #1004
Merged
Merged
Conversation
…deleted door-only static-seam row SECTION_PLANE_TEST_RUNTIME_FACTORY (BUSBAR-1.6.0.md l.1475-1478, l.1543: "no static fn-pointer seam installed into the kernel", oauth2 and admin exempt). Nothing in the workspace ever called install_test_section_plane_runtime_factory, so under an external test-support build the slot was always empty and seeded_section_plane_runtime answered None. It now answers None directly; the cfg(test) arm is unchanged. qa/door-only.toml strikes the row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTRACT-ABI lane, item 3 (the door-only static seams, part 1): the one seam nothing ever filled.
door-onlystatic-seam rule (docs/design/BUSBAR-1.6.0.mdl.1475-1478 R6 and l.1543): no static fn-pointer seam installed into the kernel; exactly the two oauth2/admin seams are exempt.qa/door-only.tomlrow:crates/busbar-kernel/src/test_support/mod.rsSECTION_PLANE_TEST_RUNTIME_FACTORY.install_test_section_plane_runtime_factoryhas no caller anywhere in the workspace on predev. Under an externaltest-supportbuild (cfg(all(not(test), feature = "test-support"))) the slot was therefore always empty, andseeded_section_plane_runtime()always answeredNone. The static, its installer and the comment that pointed at it are deleted, and that arm now answersNonedirectly. Thecfg(test)arm is unchanged. No behaviour moves in any build.RED: the drain-only
door-onlyledger strikes the row, so a reintroduced slot is a new static-seam finding.merge-treeis clean against every open PR touchingtest_support/mod.rsorqa/door-only.toml(#992, #936, #913, #893, #805).The remaining seams need a decision first; they are reported to the coordinator with a plan.