Repository navigation
fleet: busbar pin -> predev 1d111f2904; pack at the plugin's own version - #22
Open
MattJackson wants to merge 2 commits into
Open
MattJackson wants to merge 2 commits into
MattJackson wants to merge 2 commits into
Conversation
The busbar pin moves 7356bbfb6b -> predev 1d111f29049842e66f4ce3419e1219302a249b4f over the busbar-release template render #21 carries (4c47cad0385d at 276a156148), retargeted to the tip: .busbar-ref, the ci/release/repin workflow revs, the workspace busbar git deps and [patch], the fleet dependency table, the deny.toml header, and Cargo.lock (resolves with cargo metadata --locked). The contract's HostTables gained the appended io table (abi/host/io.rs); the ready test's host tables lend none (io: NULL).
plugins.yaml gives every roster plugin version_line "1.0"; 1.5.0 was a leftover of the 1.5.x line, and this repo has no tag or release, so no published high-water mark is crossed. The pack-version rule (ARCHITECT ruling C') packs at the plugin's own stated version, now 1.0.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin. busbar
7356bbfb6baeb0e9245a59dc74f8b4bfadb2c5a4-> predev tip1d111f29049842e66f4ce3419e1219302a249b4f(1.6.0). The pin moves in.busbar-ref, the workflow revs (ci, release and its consumer-verify call, repin), the workspace's busbar git deps and[patch], the fleet dependency table and thedeny.tomlheader.busbar-transport-httpmoves toa715d1ab57andbusbar-transport-tcptoeb334dd6e9, the revs busbar links at the tip.Cargo.lockmoves busbar's crates to the tip and resolves withcargo metadata --locked.Adaptations.
.github/fleet/deps.tomland busbar'sCargo.lockare identical between 276a156148 and the tip, so only the rev moves. The hunks overlap fleet: the busbar-release plugin template (CI, deps policy, settings) #21 only where the rev moves. They are disjoint from export-webhook: a userinfo in the URL is sent as authorization: Basic, as 1.5.5 sent it (audit export-webhook #1, HIGH) #19, which toucheslib.rsand an earlier region oftests.rs.export-webhook/src/tests.rs: the contract'sHostTablesgained the appendediotable (abi/host/io.rs, the host'sio.*). The ready test's host tables lend none (io: std::ptr::null()). This was the one compile error in fleet: the busbar-release plugin template (CI, deps policy, settings) #21's CI (E0063).abi::export(ABI 3) andmechanism::{call,door,ticket::Ticket}are unchanged, and so aresdk::{door,exchange},plugin_door!andexport_door!.connector::{Need, DIRECTION_OUTBOUND, EGRESS_OPEN_WEB, KEEP_NAMED}changed only in comments (the RANDOM slot is retired).Life,Held,Lent,Out,SafeandSafeSlotgained only crate-private items;Held::releasewentpub(crate)and is not called here.conn::DeclaredConns::hold_authorityhas a default.conformance_suite!surface (door,cdylib,inputs,host,tls) is unchanged. The export script now lends each batch through the dispatcher and reads only answers the host judged.far_endsis an optional input. The new RED arms come in through the macro, andconformance.jsonneeds no change.declares.json'scontract_abi3..3 still matches the export ABI.Pack-version fix (ARCHITECT ruling C').
busbar-plugin-pack --versionmust equal the plugin's own Statement version. predev has no binary-version first-party floor: first-party plugins version on independent lines (plugin-loadersign.rs:28-30). This repo has no test that packs atbusbar --version: there is nobusbar_versionhelper, noadmin_api_e2e.rsand noe2e.rs. The conformance suite opens the built cdylib, and the Statement carriesenv!("CARGO_PKG_VERSION"). So the ruling needs no hunk here. Note: the crates are versioned1.5.0, whileplugins.yamlgives this repoversion_line: "1.0".Layout proof. This is a Rust plugin. It vendors no
abi-layout.goldenorbusbar_plugin.hand has no layout assertion test. The contract it compiles against isbusbar-contractat the pin, so with the pin equal to predev's tip its compiled-in ABI layout is predev's by construction.