[MISC] Make comments on build_pos_info concise - #906
Conversation
…docstring to _build_pos_info
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f379c62db
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # node: `file`, `src`, `indent`, `lineno_offset` and the function name all derive from it and are identical | ||
| # across its transforms. Scoping it there also keeps it bounded by the function's lifetime and correct | ||
| # across a module reload, which hands out new FuncBase objects and so a new cache. | ||
| def memoized_get_pos_info(self, node: ast.AST) -> str: |
There was a problem hiding this comment.
For a commit scoped to making _build_pos_info comments concise, renaming get_pos_info here forces updates across every caller in two existing modules without changing behavior. Retain the existing method name and limit this cleanup to the comments and docstring so the change does not unnecessarily expand its contact area.
AGENTS.md reference: AGENTS.md:L9-L13
Useful? React with 👍 / 👎.
1 participant
Issue: #
Brief Summary
copilot:summary
Walkthrough
copilot:walkthrough