Skip to content

Create read only client for connection to penelopedb [Ticket #10] - #32

Open
chelseakwan wants to merge 6 commits into
mainfrom
10---create-read-only-client-for-connection-to-penelopedb
Open

chelseakwan wants to merge 6 commits into
mainfrom
10---create-read-only-client-for-connection-to-penelopedb

Conversation

@chelseakwan

Copy link
Copy Markdown
Collaborator

Overview

Provide a brief summary of the changes you made and files touched.
Created files models.py and client.py.
Models.py: creates data models that directly mirror the data model in the Penelope DB
Client.py: Created a client to query data from PenelopeDB, accounts for different querying types, includes erroring handling for accessing Penelope DB and reading data.

Technical Description

How did you achieve this goal. Explain briefly how your change achieves the ticket's ask.
Broke up the tickets into two parts so it was more digestible. Added a method of reading data fro PenelopeDB so we can write it into OrionDB in next ticket.

How Has This Been Tested?

Describe your steps for testing this work. Include screenshots or unit test files.
N/A

Ticket Review

Answer the following:

  1. What went well
  • successfully completed the ticket!
  1. What was difficult
  • had a little bit of trouble initially accessing the Penelope DB, also learned more about data modeling and error handling
  1. If you could start over what would you do differently
  • N/A, I thought it went well and was able to learn a lot

@chelseakwan chelseakwan linked an issue Sep 20, 2026 that may be closed by this pull request
@TKDPenguin
TKDPenguin requested review from TKDPenguin and a lite review from Copilot and removed request for Copilot September 20, 2026 16:00

@TKDPenguin TKDPenguin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great for the most part! The only thing is that in your PR description you put N/A under how you tested the code, but you have test_penelope.py. Did you run test_penelope.py? If so, what did it output? Did it seem correct?

@diyakadakia

Copy link
Copy Markdown
Collaborator

Yes sorry, we did test it in test_penelope.py. The output seemed correct for get_by_time_bounds and get_by_run_id. Also ran get_all() works, but times out on the full table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Penelope] Create Read-Only Client for connection to PenelopeDB

3 participants