perf(gr26): flush shelter ingest writes once per parquet chunk - #223
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ddd48a9f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
gauchoracing
approved these changes
Aug 7, 2026
Per-chunk flush errors were only logged, so processFile returned success and foreman completed the job instead of spending a retry attempt — one transient ClickHouse blip could silently drop up to 4,096 frames. Hold the first flush error and return it after the loop, so the rest of the file still lands but the attempt fails and gets retried. Report stats on the failure path too. FailRequest already carries a result, but the worker only forwarded one to Complete; wire it into Fail so a partial-failure run records failed_inserts, cans_dropped, signals_dropped and per-chunk error samples alongside the decode counts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateCANround trip plus per-signal inserts for every parquet row, ~220ms/row with ClickHouse ~25-30ms from foundry (the current 730k-row batch was tracking ~45h)processFileto decode each 4096-row chunk fully, then flush once per chunk: oneCreateCANsbatch + oneCreateSignalsbatch — two round trips per ~4096 rows instead of ~30kservice.CreateCANsbulk counterpart ofCreateCANusingPrepareBatchdispatchRowbecomes decode-only and returns the frame + signals;replayFramefolded inCreateSignals) — without it the per-chunk signal flush would still be per-signal round trips