Normalize CANdo bit_start Ranges To Plain Integers - #550
Open
coderask wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
GRCAN.CANdo, 26bit_startvalues used range notation (e.g.bit_start: 0-7) instead of plain integers (bit_start: 0). The range end is always derivable frombit_start + type_width(data_type) - 1, making it redundant information.Every Perl parser was already stripping the range on read:
DBCparser.plused$v =~ s/-.*//smx;in two placesSTRUCTparser.plonly captured(\d+)so it ignored ranges naturallyChanges
GRCAN.CANdo-- Converted all 26bit_startrange values to plain integers (just the start value).DBCparser.pl-- Removed the now-unnecessary range-stripping logic:$v =~ s/-.*//smx;from the Message ID signal parsing block (line 858).bit_startregex from([\d\-]+)to(\d+)and removed the$bs =~ s/-.*//smx;line (lines 913-915).Why