feat: add Depot omnisearch - #9
Conversation
BK1031
commented
Sep 1, 2026
BK1031
commented
- Add a Sentinel-style header search dialog with Cmd/Ctrl+K and remove the standalone Search navigation item
- Add permission-scoped fuzzy search across buckets, files, storage backends, grants, replicas, access logs, applications, and uploaders
- Add PostgreSQL trigram indexes and Sentinel name/icon enrichment with graceful fallback behavior
- Add direct file-result links that open the file detail sheet
- Depends on feat: add uploader and application detail pages #8 for the uploader and application detail destinations
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: Bharat Kathi <bharat1031@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d636a27852
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| case "application": | ||
| result.Href = "/applications/" + url.PathEscape(row.ClientID) | ||
| case "uploader": | ||
| result.Href = "/uploaders/" + url.PathEscape(row.EntityID) |
There was a problem hiding this comment.
Whenever an application or uploader matches, selecting it navigates to these generated URLs, but the reviewed router defines neither /applications/:id nor /uploaders/:id; both therefore fall through to the wildcard NotFoundPage. This makes two advertised result groups consistently unusable, so they should target existing pages or be withheld until corresponding routes exist.
Useful? React with 👍 / 👎.
| if len(bucketIDs) > 0 { | ||
| if err := database.DB.Model(&model.File{}).Where("bucket_id IN ? AND created_by_entity_id <> ''", bucketIDs).Distinct().Pluck("created_by_entity_id", &entityIDs).Error; err != nil { |
There was a problem hiding this comment.
For a user with a large accessible bucket, every query scans all files for distinct uploader IDs and then resolves every cache-missing identity through Sentinel, even though only 30 search results can be returned. After startup or cache expiry, thousands of uploaders become many serialized 100-ID network requests before any result is returned; collect identities only from matched rows or otherwise cap/filter this lookup by the query.
Useful? React with 👍 / 👎.
1 participant
