Skip to content

fix(web): match Sentinel application icon fallbacks #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BK1031 merged 1 commit into from
Sep 1, 2026
Merged

fix(web): match Sentinel application icon fallbacks #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 23 additions & 15 deletions web/src/components/ApplicationDisplay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { AppWindow } from "lucide-react"
import { useState } from "react"

import type { SentinelApplication } from "@/lib/depot"
import { cn } from "@/lib/utils"
Expand All @@ -7,34 +7,42 @@ type ApplicationVisual = Pick<SentinelApplication, "name" | "client_id" | "icon_
type DisplaySize = "sm" | "md"

const iconSizes: Record<DisplaySize, string> = {
sm: "size-6 rounded-md",
md: "size-8 rounded-lg",
sm: "size-6 rounded-md text-xs",
md: "size-8 rounded-lg text-sm",
}

export function ApplicationIcon({
application,
fallbackName,
size = "md",
}: {
application?: ApplicationVisual
fallbackName?: string
size?: DisplaySize
}) {
if (application?.icon_url) {
return (
<img
src={application.icon_url}
alt=""
className={cn(iconSizes[size], "shrink-0 object-cover")}
/>
)
}
const [failedURL, setFailedURL] = useState<string | null>(null)
const name = application?.name || fallbackName || application?.client_id || "Unknown application"
const imageURL =
application?.icon_url && failedURL !== application.icon_url ? application.icon_url : null

return (
<span
className={cn(
iconSizes[size],
"flex shrink-0 items-center justify-center bg-gradient-to-br from-gr-purple to-gr-pink text-white",
"flex shrink-0 items-center justify-center overflow-hidden",
!imageURL && "bg-gradient-to-br from-gr-pink to-gr-purple font-semibold text-white",
)}
>
<AppWindow className={size === "sm" ? "size-3" : "size-4"} />
{imageURL ? (
<img
src={imageURL}
alt={name}

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 31, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the application icon hidden from assistive technology

When a screen-reader user encounters any current caller, the icon is immediately followed by the same application name, so alt={name} causes configured icons to announce the name twice; the textual initial fallback is likewise exposed. Keep this visual decorative (for example, hide the wrapper from assistive technology and restore an empty image alt) so buttons and identity rows retain a single accessible label.

Useful? React with 👍 / 👎.

className="size-full object-contain"
onError={() => setFailedURL(imageURL)}
/>
) : (
(name.slice(0, 1) || "?").toUpperCase()
)}
</span>
)
}
Expand All @@ -55,7 +63,7 @@ export function ApplicationDisplay({
const name = application?.name || clientID || "Unknown application"
return (
<div className={cn("flex min-w-0 items-center gap-2.5", className)}>
<ApplicationIcon application={application} size={size} />
<ApplicationIcon application={application} fallbackName={clientID} size={size} />
<span className="flex min-w-0 flex-col leading-tight">
<span className={cn("truncate font-medium", size === "sm" ? "text-xs" : "text-sm")}>
{name}
Expand Down
Loading