Repository navigation
Conversation
Signed-off-by: Baylem <zelathis@gmail.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 17 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
Baylem
left a comment
Baylem
left a comment
There was a problem hiding this comment.
Reviewed the storage sampler, heartbeat and dashboard through 49f61e05. The sampler uses the server directory, excludes nested mounts and handles sparse files, hard links and files that disappear during a scan. Capacity stays unknown when there is no measured quota. The follow-up fixes sample expiration at the deadline and exercises cancellation and retries.
Verification included ten consecutive Linux usage-suite passes, 128 of 133 changed agent lines covered (96.2%), the agent lint configuration, dashboard coverage and the updated Pencil screens. Linux tests exercised a same-device bind mount in a private mount namespace. The quota reader was tested with real filesystem attributes and representative CephFS values. A live CephFS deployment remains unverified.
CI Report - 49f61e0run 43164141097 - attempt 1 0 failed - 1 passed - 3 skipped - 29 cancelled - 6m39s elapsed Test selection: partial - per-suite table Coverageno coverage/* commit statuses found on 49f61e0 Changed
Slowest jobs
e2e buckets run
|
Signed-off-by: Baylem <zelathis@gmail.com>
Report storage for each server from its data directory. Kernel CephFS can supply recursive usage and a directory quota. Other filesystems use a time- and entry-bounded background scan that counts allocated blocks and hard links once, excludes nested mounts, and keeps the heartbeat responsive. The dashboard labels the requested claim size when observed capacity is unavailable.
Verified the Linux usage, heartbeat, and Prometheus suites, the Overview suite, TypeScript, and Go vet. A private Linux mount namespace exercised a real bind mount on the same device. Provider counter tests cover known zero, absent quota, and unavailable attributes. Ten consecutive Linux usage-suite runs passed. The agent covered 128 of 133 changed lines (96.2%). Both updated Overview screens passed the browser-to-Pencil comparison and pseudo-locale clipping checks. Live CephFS validation remains outstanding.
Closes #937.