Repository navigation
Conversation
Signed-off-by: Baylem <zelathis@gmail.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 14 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Signed-off-by: Baylem <zelathis@gmail.com>
CI Report - 34169a6run 43162526674 - attempt 1 0 failed - 4 passed - 3 skipped - 26 cancelled - 13m6s elapsed Test selection: partial - per-suite table Coverageno coverage/* commit statuses found on 34169a6 Changed
Slowest jobs
e2e buckets run
|
Signed-off-by: Baylem <zelathis@gmail.com>
Baylem
commented
Nov 12, 2026
Baylem
left a comment
Baylem
left a comment
Member
Author
There was a problem hiding this comment.
Reviewed worker construction, Restic summary parsing, the optional Backup field, CRD copies, both lists, and the detail drawer. A disposable Restic 0.19.1 repository selected the prior snapshot after a worker change, kept a replacement server in its own parent group, and restored the original backup by ID byte-for-byte. Regression tests preserve logical size and distinguish missing packed bytes, measured zero, and a positive byte count with units. Both the operator and dashboard passed their changed-line coverage gates.
Signed-off-by: Baylem <zelathis@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bind new Restic workers to the captured GameServer UID so successive backups of the same source can reuse a parent. Record the packed bytes added by a run separately from logical snapshot size. The field is optional for older and CSI backups and preserves an explicit zero. Both backup lists and the detail drawer display it.
The operator suite, TypeScript build and 68 backup dashboard tests passed. Four browser scenarios checked the packed-byte display. All three updated Pencil screens passed the standard visual comparison. A disposable Restic 0.19.1 repository selected the prior snapshot for a repeated server identity, selected no parent for a replacement identity, and restored the original snapshot by ID byte-for-byte.
Closes #933.