Skip to content

test(e2e): fit the ARK Evolved timeouts to a first install - #924

Open
ValgulNecron wants to merge 2 commits into
masterfrom
fix/ark-e2e-timeouts
Open

test(e2e): fit the ARK Evolved timeouts to a first install#924
ValgulNecron wants to merge 2 commits into
masterfrom
fix/ark-e2e-timeouts

Conversation

@ValgulNecron

@ValgulNecron ValgulNecron commented Nov 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

This follow-up to #915 fixes the two timeout findings CodeRabbit left on its last review. The maintainer signed off on both changes.

  • Cluster test (arksurvival_cluster_persistence_e2e_test.go): the cluster-dir wait drops from 45 to 30 minutes. Before, the waits added up to 59 minutes (2 + 5 + 45 + 5 + 2), more than the 50-minute go test -timeout in make test-e2e-keep.
  • Bot test (arksurvivalevolved_bot_e2e_test.go): the GameServer reports Running before SteamCMD has finished the ~25GB install, so a 4-minute A2S probe could expire. The positive probe now gets 30 minutes.
  • Helper (gamebot_helpers_e2e_test.go): adds an optional NegativeDeadline to gameBotSpec for the negative-control probe. It falls back to ProbeDeadline when unset, so every other game test behaves as before. ARK keeps its negative control at 4 minutes.

Verification

go test -tags e2e -c compiles. Both ARK tests are hand-run only and never run in CI.

Generated by Claude Code

@claude
test(e2e): fit the ARK Evolved timeouts to a first install
a8cd949 
The cluster test's waits added up to 59 minutes, over make
test-e2e-keep's 50-minute go test timeout, so the cluster-dir wait
drops from 45 to 30 minutes.

The bot test's 4-minute probe deadline could expire while SteamCMD
is still installing, since the server reports Running first. ARK now
gives the positive probe 30 minutes. A new optional NegativeDeadline
on gameBotSpec keeps its negative control at 4 minutes; it falls back
to ProbeDeadline, so no other game test changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@ValgulNecron ValgulNecron added area: e2e kind-based end-to-end suite type: test Test additions or changes labels Nov 11, 2026 — with Claude
@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 24 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 8ca4f1b and 9e8b155.

Files selected for processing: 3

  • test/e2e/arksurvival_cluster_persistence_e2e_test.go
  • test/e2e/arksurvivalevolved_bot_e2e_test.go
  • test/e2e/gamebot_helpers_e2e_test.go
Pre-merge checks: Passed 1 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Title check Pending This assessment has not completed. The check will be retried on the next pre-merge check run.
Passed Passed checks: 1 passed

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@ValgulNecron Claude

ValgulNecron commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator Author

These five red checks are a GitHub Actions artifact-service outage, not this PR:

  • e2e postgres / amd64
  • e2e operator / arm64
  • e2e game bot / TestGameServer_TerrariaBot_Joined
  • e2e game bot / TestGameServer_GarrysModBot_Query
  • vuln (images)

Every one of them failed in the load images step, before any test or scan ran. The step couldn't download the e2e-images artifact: GetSignedArtifactURL got back HTML or upstream connect errors, and later a 404 artifact not found for an artifact this same run built minutes earlier. The build e2e images jobs passed, as did every e2e job that got its download through. This PR only changes hand-run ARK test timeouts. I'll re-run the failed jobs once when the run finishes.

Generated by Claude Code

@ValgulNecron ValgulNecron mentioned this pull request Nov 11, 2026
Open
@github-actions

github-actions Bot commented Nov 11, 2026 •
edited
Loading

Copy link
Copy Markdown

CI Report - 9e8b155

run 43139731776 - attempt 1

0 failed - 13 passed - 20 skipped - 83m38s elapsed

Test selection: partial - per-suite table

Coverage

no coverage/* commit statuses found on 9e8b155

Changed

Area Files +/-
test/ 3 +24/-14

Slowest jobs

Job Duration
build e2e images 18m3s
e2e game bot / TestGameServer_GarrysModBot_Query (kind) 11m53s
e2e game bot / TestGameServer_MinecraftJavaBot_Joined (kind) 10m58s
build e2e images (arm64) 10m53s
e2e game bot / TestGameServer_TerrariaBot_Joined (kind) 9m36s

e2e buckets run

api-agent, api-auth, api-mods, api-rbac, api-roles, backup-preparation, bot-fast, management-placement, monitoring, multicluster, network-isolation, operator, optional-components, postgres-availability, restricted-workloads, telemetry, upgrade

@claude
Merge remote-tracking branch 'origin/master' into fix/ark-e2e-timeouts
9e8b155 
Signed-off-by: Claude <noreply@anthropic.com>

# Conflicts:
#	test/e2e/gamebot_helpers_e2e_test.go

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area: e2e kind-based end-to-end suite type: test Test additions or changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ValgulNecron @claude