Repository navigation
Conversation
Signed-off-by: Baylem <zelathis@gmail.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 10 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Baylem
added
area: chart
Signed-off-by: Baylem <zelathis@gmail.com>
Signed-off-by: Baylem <zelathis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed during the whole-issue scope review. #882 still needs a populated Argo CD sync, prune and trust-rotation run with authenticated agents and a waker authorization check.
Part of #882. This PR covers native offline rendering, explicit Argo CD retention and reusable populated-upgrade assertions. #882 stays open for the live Argo CD controller drill.
The opt-in profile uses existing external CA and client Secret settings and derives both workload checksums from versioned Secret names. It rejects chart-generated credentials, missing waker admission capabilities and competing CRD apply hooks. The games Namespace and SQLite PVC carry explicit Argo CD prune and Application deletion protection. The runbook assigns CRDs to a separate Application, describes adoption of the existing database, and sequences CA/client rotation and authenticated checks.
The chart CI fixture compares full manifests, checks admission and retention objects, verifies Secret rotation inputs and exercises invalid configurations. The populated Helm upgrade fixture compares the API claim UID, CRD UIDs and public CA continuity, and checks that live stored versions still exist in the CRD schema.
Local Helm 4.3.1 renders for two installs and an upgrade produced identical bytes. A changed client Secret reference changed both checksums. Omitting the binding capability produced the expected configuration error. The E2E package and Python fixture syntax compiled, and the staged diff passed the whitespace check.
The profile uses the current trust layout on master. After #886 and any issuer layout changes, qualify a populated Argo CD sync, prune and controlled rotation with the final Secrets, a denied waker mutation and fresh authenticated agent calls.