Skip to content

Fix yaml-cpp exception symbol visibility #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anderkve merged 3 commits into from
May 8, 2026
Merged

Fix yaml-cpp exception symbol visibility #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5f9f6e
Fix yaml-cpp exception symbol visibility (undefined symbol _ZTIN4YAML…
claude May 8, 2026
1b29a2b
Add explanatory comment for ENABLE_EXPORTS on GAMBIT executables
claude May 8, 2026
ea112f8
Shorten ENABLE_EXPORTS comment to two sentences
claude May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion cmake/utilities.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,15 @@ function(add_gambit_executable executablename LIBRARIES)
cmake_parse_arguments(ARG "" "" "SOURCES;HEADERS;" ${ARGN})

add_executable(${executablename} ${ARG_SOURCES} ${ARG_HEADERS})
set_target_properties(${executablename} PROPERTIES EXCLUDE_FROM_ALL 1)
# ENABLE_EXPORTS adds -rdynamic/-export_dynamic to the linker so that dlopen'd backends
# and scanner plugins can resolve symbols from statically linked contrib libraries (e.g.
# yaml-cpp exception typeinfo). Setting this via a target property rather than
# CMAKE_CXX_FLAGS keeps GAMBIT's own code compiled with -fvisibility=hidden, so only
# contrib symbols built with default visibility are exported, not GAMBIT internals.
set_target_properties(${executablename} PROPERTIES
EXCLUDE_FROM_ALL 1
ENABLE_EXPORTS TRUE
)

if(${CMAKE_VERSION} VERSION_GREATER 2.8.10)
foreach (dir ${GAMBIT_INCDIRS})
Expand Down
2 changes: 2 additions & 0 deletions contrib/yaml-cpp-0.6.2/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,6 @@ endif()

set_target_properties(yaml-cpp PROPERTIES
ARCHIVE_OUTPUT_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}"
CXX_VISIBILITY_PRESET default
VISIBILITY_INLINES_HIDDEN FALSE
)
Loading