Skip to content

fix: merge installer w mod - #108

Merged
GaganSD merged 5 commits into
mainfrom
fix/insights-single-mod
Nov 2, 2026
Merged

GaganSD merged 5 commits into
mainfrom
fix/insights-single-mod

Conversation

@GaganSD

@GaganSD GaganSD commented Nov 2, 2026

Copy link
Copy Markdown
Owner
  • Consolidate the toolbar button and dashboard into one native insights mod, selected through Herdr’s per-copy props.
  • Remove the separate launcher, multi-mod installer plumbing, and redundant documentation; keep fresh-install behavior only.
  • Verify lightweight toolbar lifecycle, dashboard reuse, and single-mod installation with 183 passing tests, package checks, lint, and local native smoke tests.

- Describe the merged toolbar/dashboard mod with props mode in README,
  RECIPE, INSTALL, and the development guide
- Keep INSTALL.md installation-only and short; drop uninstall and dual-mod copy
- Decouple the package validator from core MOD_NAMES and require exactly one
  mods/insights directory
- Assert the single-mod distribution and doc contract in distribution tests
@GaganSD GaganSD changed the title Keep Insights as one native mod fix: merge installer w mod Nov 2, 2026
@greptile-apps

greptile-apps Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable failures were found.

Summary

Merges the toolbar button and dashboard into one native insights mod.

  • One Insights mod renders both the toolbar button and dashboard.
  • The local installer and uninstaller track one Insights mod.
  • The Insights package accepts one native mod directory.

No actionable issues were found. Review checks were source-based; tests and native Herdr checks were not run.

GaganSD explicitly limits this PR to “fresh-install behavior only,” so launcher migration and cleanup are intentionally out of scope.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Herdr mounts insights] --> B{props.mode is toolbar?}
  B -->|Yes| C[Render Insights button]
  B -->|No| D[Start dashboard work]
  D --> E[Render dashboard]
  C --> F{Dashboard exists in active space?}
  F -->|Yes| G[Reveal and focus its pane]
  F -->|No| H[Open Insights tab]
Loading

Reviews (1) · Last reviewed commit: "Read toolbar mode from Herdr per-copy pr..." · Reviewed by Greptile

@GaganSD
GaganSD merged commit ccfe934 into main Nov 2, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant