Repository navigation
Add Insights to Herdr toolbar - #107
Merged
Merged
Conversation
GaganSD
changed the title
- Replace per-mod special cases with one MODS table for manifest and runtime rules - Resolve app home once in uninstall and drop duplicate existence checks - Reuse the layout name assertion instead of validating via a discarded path - Clone layout trees with structuredClone and drop the redundant record suffix check - Remove the pre-toolbar --open flag; the Insights button replaces it - Hoist duplicated test fixtures and tree snapshots
- Resolve source root, app home, and the Node gate once in install main - Validate every source before creating the app home; keep force and the launcher-conditional toolbar preparation explicit - Give MODS the mod path and optional flag, validate names in one place, and drop the dashboard defaults from modDir/manifestPath/readManifest/writeManifest - Move toolbar/launcher install tests and shared fixtures out of the 1000-line install.test.mjs into toolbar-install.test.mjs and install-fixtures.mjs
When 53 weeks of 12px cells cannot fit, the grid overflowed to the right and the viewport showed the oldest columns. Align an overflowing grid to the end so the visible columns are the most recent weeks; wide views stay centered.
The scroll wrapper sized its content to the grid, so justify_end had no free space and the viewport still showed the oldest weeks. Clip the row directly so end alignment shifts the grid left and the newest weeks stay visible.
The 960px breakpoint left wide-but-not-huge panes in one column of ten rows. Two columns need roughly 340px each, so gate on 740px and pin the breakpoint with a regression test.
Locate an existing tab whose pane runs the insights mod and select it; create a tab only when the current space has none, so repeated clicks cannot stack duplicate dashboards.
Replace the 740px breakpoint with a wrapping row: two five-row columns with a minimum readable width, so the layout splits only when both actually fit and falls back to one column at any smaller size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tabsmod unchanged.Validation:
npm run test:insights(170 passing) andnpm run check:insights.